Skip to content

Update Vibe.d to v0.9.0 in test_registry & dub init#1994

Merged
wilzbach merged 2 commits intodlang:masterfrom
Geod24:vibe-d-update-again
Aug 13, 2020
Merged

Update Vibe.d to v0.9.0 in test_registry & dub init#1994
wilzbach merged 2 commits intodlang:masterfrom
Geod24:vibe-d-update-again

Conversation

@Geod24
Copy link
Member

@Geod24 Geod24 commented Aug 13, 2020

Needed for dlang/phobos#7545

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @Geod24!

@jblachly
Copy link

@Geod24 do you have commit access to dub as well? dub init -t vibe.d still emits version 0.8.6 as well.

@Geod24
Copy link
Member Author

Geod24 commented Aug 13, 2020

Thanks for the info, added an extra commit. Yes I have push access but I'm sure someone will be able to review this today.

@jblachly
Copy link

Didn't realize we were already in dub repo heh -- thanks for adding the extra commit to the PR

@Geod24 Geod24 changed the title Update Vibe.d to v0.9.0 in test_registry Update Vibe.d to v0.9.0 in test_registry & dub init Aug 13, 2020
Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ~>0.x is bad because major v0 versions may introduce breaking changes with minor updates. Even though vibe.d already acts pretty stable like a v1 version, I think it would be a bad practice promoting ~>0.x.

Once vibe.d goes 1.x I would be all for ~>1.x though

@Geod24
Copy link
Member Author

Geod24 commented Aug 13, 2020

But it's dub init. You won't break anything by creating a new repo.

Ah but it shouldn't end in the dub.json I suppose.

@WebFreak001
Copy link
Member

even if it's a new repo, new vibe.d updates will be released with the code that was once written based on this generated dub init then. Furthermore seeing the ~>0.x syntax will promote its usage possibly also by people without knowledge that it means >=0.x.0 <1.0.0 and how minor versions in SemVer may break code with a major v0

The ~>0.x.y syntax is more stable for that as it means >=0.x.y <0.z.0 where z is x+1 (~>0.9.0 => >=0.9.0 <0.10.0)

@Geod24
Copy link
Member Author

Geod24 commented Aug 13, 2020

The ~>0.x.y syntax is more stable for that as it means >=0.x.y <0.z.0 where z is x+1 (~>0.9.0 => >=0.9.0 <0.10.0)

That's not quite true:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

The argument for not having ~>0.x is that according to SemVer, major == 0 means "anything goes". So that same reasoning applies to patch releases.

@andre2007
Copy link
Contributor

Regarding the ctrl+c issue of vibe-d (still reproducible with vibe-d 0.9.0 according to a user in the dlang forum), what do you think about defaulting VibeHighEventPriority in dub init?

@wilzbach
Copy link
Contributor

So that same reasoning applies to patch releases.

Yes, but in practice patch releases are more stable.

Anyhow, I don't really think it matters and 0.9 means that we don't have to update dub constantly (or won't break when it can't be updated).

@wilzbach
Copy link
Contributor

what do you think about defaulting VibeHighEventPriority in dub init?

It would take months for most users to update to the newest dub release (the next release this could be in is 1.11). And no one immediately updates their compiler, so I would say at least half a year until this has an impact on beginners. Furthermore, I think they would be confused because tutorials don't mention the version flag.
So I think the issue should just be fixed or in the worst case vibed's default configuration could default to adding the version flag.

@Geod24
Copy link
Member Author

Geod24 commented Aug 13, 2020

So what do I do with this PR ?

@wilzbach wilzbach merged commit d61fcd2 into dlang:master Aug 13, 2020
@Geod24 Geod24 deleted the vibe-d-update-again branch August 13, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants