Skip to content

std.digest.digest: Update deprecation comment#7545

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:rmdeprecated
Mar 19, 2021
Merged

std.digest.digest: Update deprecation comment#7545
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:rmdeprecated

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jun 26, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7545"

@MoonlightSentinel
Copy link
Contributor

Already made a PR for enforceEx: #7283
It's currently blocked on a new vibe.d release.

Geod24 added a commit to Geod24/vibe-core that referenced this pull request Aug 2, 2020
This function wasn't used anymore, but still imported, despite being deprecated.
It was scheduled to be removed a few releases ago (see dlang/phobos#7545).
@Geod24
Copy link
Member

Geod24 commented Aug 2, 2020

It's currently blocked on a new vibe.d release.

Actually, I think it is actually blocked on a new vibe-core release (since Vibe.d v0.9.0 was released recently).
Will take care of that.

Geod24 added a commit to vibe-d/vibe-core that referenced this pull request Aug 2, 2020
This function wasn't used anymore, but still imported, despite being deprecated.
It was scheduled to be removed a few releases ago (see dlang/phobos#7545).
@Geod24
Copy link
Member

Geod24 commented Aug 3, 2020

Vibe-core release is done, so this should not be blocked anymore.

@ibuclaw ibuclaw force-pushed the rmdeprecated branch 2 times, most recently from ddc415d to fa96357 Compare August 3, 2020 10:03
@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 3, 2020

Rebased, let's see...

@Geod24
Copy link
Member

Geod24 commented Aug 3, 2020

Oh well Vibe.d is fixed but now we need to update the dependencies of a bunch of programs

@Geod24
Copy link
Member

Geod24 commented Aug 4, 2020

Running DScanner
--
  | generated/dscanner-9364d6f15f4a610fda49a693dbc18608bfc701bb/dsc --config .dscanner.ini --styleCheck etc std -I.
  | posix.mak:562: recipe for target 'dscanner' failed

The style target is still failing, can you look into it ?
Everything else but dub has been fixed. I'll look into dub a bit later.

@Geod24
Copy link
Member

Geod24 commented Aug 9, 2020

dub PR has been merged, I just re-triggered Buildkite. Can you add a release note entry ?
Just a one liner is enough IMO.

@thewilsonator
Copy link
Contributor

thewilsonator commented Nov 4, 2020

@ibuclaw CI seems stuck, can you please rebase.

@Geod24
Copy link
Member

Geod24 commented Nov 4, 2020

And add the release not entry.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 4, 2020

And add the release not entry.

What's the point when more than half of the functions originally in this PR have already been removed without note.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 4, 2020

@thewilsonator rebased.

@Geod24
Copy link
Member

Geod24 commented Nov 4, 2020

What's the point when more than half of the functions originally in this PR have already been removed without note.

That's not an example to follow IMO.

@Geod24
Copy link
Member

Geod24 commented Nov 4, 2020

For reference, the point is to make it easier to search in release notes.

@ibuclaw
Copy link
Member Author

ibuclaw commented Nov 4, 2020

For reference, the point is to make it easier to search in release notes.

Well I think one of them was rndtol, but no idea what the others were by now.

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 1, 2021

Rebased and Ping!

@thewilsonator
Copy link
Contributor

../.dub/packages/vibe-d-0.8.6/vibe-d/utils/vibe/internal/memory_legacy.d(9,8): Error: module `std.exception` import `enforceEx` not found, did you mean template `std.exception.enforce(E : Throwable = Exception) if (is(typeof(new E("", string.init, size_t.init)) : Throwable) || is(typeof(new E(string.init, size_t.init)) : Throwable))`?

@berni44
Copy link
Contributor

berni44 commented Mar 18, 2021

@ibuclaw IMHO this one can be closed. All functions are meanwhile removed.

@ibuclaw ibuclaw changed the title Remove deprecated functions (should have been removed in 2.090) std.digest.digest: Update deprecation comment Mar 19, 2021
@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 19, 2021

Rebased, there's still a one-liner change remaining.

@ibuclaw ibuclaw added Review:Trivial typos, formatting, comments and removed Review:Easy Review labels Mar 19, 2021
@dlang-bot dlang-bot merged commit 2f71550 into dlang:master Mar 19, 2021
@ibuclaw ibuclaw deleted the rmdeprecated branch March 20, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants