Conversation
There was a problem hiding this comment.
as this function is not used directly in your tests I suppose it should be private and named meanImpl
There was a problem hiding this comment.
|
Hi @JackStouffer!
|
Ok, I'm not quite sure how to make a branch off of a PR though.
I agree. Following this, I believe the |
You can fork my phobos repo and switch to the corresponding branch. Please read last comments starting with #2991 (comment) . Summation API can be changed during October. You are welcome for API review.
|
|
Glad to see this is converging on nice package names and goes in the right direction ;) |
Split from #3592
I will propose the same question I had in the other PR
Also fixes issue 14034