Conversation
There was a problem hiding this comment.
You sure this is how it is supposed to be? This file doesn't get built by @CyberShadow's autotester, so it's hard for me to know whether this works.
I find it hard to believe that this needs 5 parameters.
There was a problem hiding this comment.
You sure this is how it is supposed to be? This file doesn't get built by @CyberShadow's autotester, so it's hard for me to know whether this works.
I've built it with dmd ../dlang.org/{std,html,dlang.org,macros}.ddoc -Dfchangelog.html changelog.dd. The page doesn't look pretty, but one can see that it generates this href:
../phobos/std_experimental_allocator_gc_allocator.html#GCAllocator.goodAllocSize
Which looks ok. Though I've just noted that it seems to miss a dot in front of "GCAllocator". But that must be fixed in the REF macro, I think.
I find it hard to believe that this needs 5 parameters.
Well, the module hierarchy is that deep and REF takes the segments individually, as it needs to join them differently two times: once with dots for the name, once with underscores for the URL.
There was a problem hiding this comment.
ok.
BTW, I totally understand why very few people do anything for ddoc improvements. I have no idea how to correctly use the various macros.
This LGTM.
There was a problem hiding this comment.
But that must be fixed in the REF macro, I think.
There was a problem hiding this comment.
The REF macro supersedes a number of less generic macros for cross-referencing. It is used correctly here.
edit: that said I don't think the inconsistent use of whitespace here is justified.
2.070 has been released, and its changelog in the dlang.org repository has these entries.
aG0aep6G
force-pushed
the
cleanup-changelog
branch
from
921eb97 to
174c78b
Compare
|
LGTM, but I have no idea how the new changelog system works. Some time ago I looked around for any info on it to no avail. It'd be a nice development if anyone with a grip on how it should be used would put it in CONTRIBUTING.md or on the Wiki. |
|
AIUI, before a release, the release manager (Martin) essentially copies the contents of each component's changelog and pastes them in the main D changelog on the dlang.org repo. |
|
@CyberShadow that is correct |
|
Ping? Any problems with this? |
|
I'm gonna go ahead and pull this, It's not even used until the next full release, so if there's problems they can be worked out. Thanks. |
|
Auto-merge toggled on |
4 participants
Removing old entries, fixing a link.