Skip to content

Cleanup changelog #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schveiguy merged 2 commits into from
Feb 9, 2016
Merged

Cleanup changelog #3964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717f0a8
remove entries for 2.070 from changelog
aG0aep6G Feb 3, 2016
174c78b
fix broken link
aG0aep6G Feb 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions changelog.dd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,13 @@ $(COMMENT Pending changelog for 2.071. This will get copied to dlang.org and

$(BUGSTITLE Library Changes,

$(LI $(RELATIVE_LINK2 json-encode-control-characters, `std.json` encodes string control characters.))
$(LI The package $(STDMODREF experimental_ndslice, std.experimental.ndslice) was added.
It is also available as part of the $(LINK2 https://github.com/DlangScience/mir, Mir library).)
$(LI Default LogLevel of FileLogger was changed to LogLevel.all.)
$(LI Access to the internal `ptr` and `len` fields of $(XREF bitmanip, BitArray) was deprecated.)
$(LI $(XREF experimental.allocator.gc_allocator, GCAllocator.goodAllocSize)
$(LI $(REF GCAllocator.goodAllocSize, std,experimental,allocator,gc_allocator)
Copy link
Member

@schveiguy schveiguy Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure this is how it is supposed to be? This file doesn't get built by @CyberShadow's autotester, so it's hard for me to know whether this works.

I find it hard to believe that this needs 5 parameters.

Copy link
Contributor Author

@aG0aep6G aG0aep6G Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure this is how it is supposed to be? This file doesn't get built by @CyberShadow's autotester, so it's hard for me to know whether this works.

I've built it with dmd ../dlang.org/{std,html,dlang.org,macros}.ddoc -Dfchangelog.html changelog.dd. The page doesn't look pretty, but one can see that it generates this href:

../phobos/std_experimental_allocator_gc_allocator.html#GCAllocator.goodAllocSize

Which looks ok. Though I've just noted that it seems to miss a dot in front of "GCAllocator". But that must be fixed in the REF macro, I think.

I find it hard to believe that this needs 5 parameters.

Well, the module hierarchy is that deep and REF takes the segments individually, as it needs to join them differently two times: once with dots for the name, once with underscores for the URL.

Copy link
Member

@schveiguy schveiguy Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

BTW, I totally understand why very few people do anything for ddoc improvements. I have no idea how to correctly use the various macros.

This LGTM.

Copy link
Contributor Author

@aG0aep6G aG0aep6G Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that must be fixed in the REF macro, I think.

dlang/dlang.org#1223

Copy link
Contributor

@JakobOvrum JakobOvrum Feb 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REF macro supersedes a number of less generic macros for cross-referencing. It is used correctly here.

edit: that said I don't think the inconsistent use of whitespace here is justified.

was added.)

)

$(BUGSTITLE Library Changes,

$(LI $(LNAME2 json-encode-control-characters, `std.json` encodes string control characters.)

$(P Instead of throwing a $(XREF json, JSONException), $(XREF json, toJSON)
encodes now the control characters of a string.
)

------
assert(toJSON(JSONValue("foo\u007fbar") == `"foo\u007Fbar"`);
------
)

)

Macros:
Expand Down