Skip to content

Comments

make Unique.opDot() inout#4662

Merged
WalterBright merged 4 commits intodlang:masterfrom
Cauterite:patch-1
Jul 27, 2016
Merged

make Unique.opDot() inout#4662
WalterBright merged 4 commits intodlang:masterfrom
Cauterite:patch-1

Conversation

@Cauterite
Copy link
Contributor

typecons.Unique.opDot() should be inout to allow use through const access paths.

typecons.Unique.opDot() should be inout to allow use through const access paths.
god forbid anyone have a tab in their code ¬_¬
std/typecons.d Outdated
unittest
{
struct Bar {int val;}
struct Foo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace style

std/typecons.d Outdated
assert(!uf2.isEmpty);
}

unittest
Copy link
Contributor

@JackStouffer JackStouffer Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a comment here describing what the unittest is for

@WalterBright WalterBright merged commit dc56fc1 into dlang:master Jul 27, 2016
@Cauterite Cauterite deleted the patch-1 branch July 27, 2016 01:07
@JackStouffer
Copy link
Contributor

This should not have been merged without a squash :/

@wilzbach
Copy link
Contributor

This should not have been merged without a squash :/

Well on the bright side we have saved for eternity that we are "brace Nazis" :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants