Skip to content

make Unique.opDot() inout #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WalterBright merged 4 commits into from
Jul 27, 2016
Merged

make Unique.opDot() inout #4662

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0fb999
make Unique.opDot() inout
Cauterite Jul 26, 2016
052fcc9
tab -> spaces
Cauterite Jul 26, 2016
52110d9
appeasing the brace Nazis
Cauterite Jul 26, 2016
e50b77f
document unittest
Cauterite Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion std/typecons.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public:
return u;
}
/** Forwards member access to contents. */
RefT opDot() { return _p; }
auto opDot() inout { return _p; }

/**
Postblit operator is undefined to prevent the cloning of $(D Unique) objects.
Expand Down Expand Up @@ -288,6 +288,26 @@ private:
assert(!uf2.isEmpty);
}

// ensure Unique behaves correctly through const access paths
@system unittest
{
struct Bar {int val;}
struct Foo
{
Unique!Bar bar = new Bar;
}

Foo foo;
foo.bar.val = 6;
const Foo* ptr = &foo;
static assert(is(typeof(ptr) == const(Foo*)));
static assert(is(typeof(ptr.bar) == const(Unique!Bar)));
static assert(is(typeof(ptr.bar.val) == const(int)));
assert(ptr.bar.val == 6);
foo.bar.val = 7;
assert(ptr.bar.val == 7);
}

// Used in Tuple.toString
private template sharedToString(alias field)
if (is(typeof(field) == shared))
Expand Down