Skip to content

Comments

Avoid deprecation warning from getSymbolsByUDA.#4724

Closed
rcorre wants to merge 1 commit intodlang:masterfrom
rcorre:fix-symbols-by-uda
Closed

Avoid deprecation warning from getSymbolsByUDA.#4724
rcorre wants to merge 1 commit intodlang:masterfrom
rcorre:fix-symbols-by-uda

Conversation

@rcorre
Copy link
Contributor

@rcorre rcorre commented Aug 10, 2016

Due to more strict accessibility rules, getSymbolsByUDA can no longer
return non-public members, as they are not visible to std.traits.

See discussion in #3827.

Due to more strict accessibility rules, getSymbolsByUDA can no longer
return non-public members, as they are not visible to `std.traits`.

See discussion in dlang#3827.
@andralex
Copy link
Member

what's with travis?

@wilzbach
Copy link
Contributor

wilzbach commented Aug 10, 2016

what's with travis?

We seem to get some weird networks errors lately. CC @MartinNowak
@MartinNowak already included a retry loop quite recently (dlang/installer#187), but it seems that it doesn't help if the server isn't available :/
In any case

  • Travis is just running coverage analysis for Phobos / Druntime atm
  • One of the reasons we want to switch to CircleCi (Switch to CircleCi #4719), is that Travis got less reliable and clogged lately
  • you can restart Travis manually if you want (-> restart build)

@MartinNowak
Copy link
Member

One of the reasons we want to switch to CircleCi (#4719), is that Travis got less reliable and clogged lately

To put it more correctly, we clogged our Travis-CI fair use share (accounted on dlang), by slowing down dmd by ~1.5x and then doubling the tests by adding 32-bit. As you see from the response times, reducing our test times to an acceptable level fixed that.
Regarding the test failure (which is about downloading dub). Maybe @s-ludwig redeployed the website recently or had some other issues? But we should definitely work on the reliability of the site (for dub) and the downloads (for the installer).
A simple fix would be to mirror the dub downloads on our downloads.dlang.org site or simply upload them to github releases. With 2.072.0 dub will be contained in dmd releases anyhow.

@MartinNowak
Copy link
Member

Due to more strict accessibility rules, getSymbolsByUDA can no longer
return non-public members, as they are not visible to std.traits.

Let's not rush this PR and wait how we resolve visibility of private members in meta code.

@MartinNowak
Copy link
Member

Think this can be closed now, the next release will allow getMember to pass visibility checks. Access checks for getMember will be dropped in a later release (though likely are marked unsafe).

@andralex
Copy link
Member

alrighty

@andralex andralex reopened this Sep 17, 2016
@rcorre
Copy link
Contributor Author

rcorre commented Sep 18, 2016

@andralex did you mean to reopen it? It sounded like you were agreeing with closing it :)

@andralex
Copy link
Member

sorry!

@andralex andralex closed this Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants