Avoid deprecation warning from getSymbolsByUDA.#4724
Avoid deprecation warning from getSymbolsByUDA.#4724rcorre wants to merge 1 commit intodlang:masterfrom
Conversation
Due to more strict accessibility rules, getSymbolsByUDA can no longer return non-public members, as they are not visible to `std.traits`. See discussion in dlang#3827.
|
what's with travis? |
We seem to get some weird networks errors lately. CC @MartinNowak
|
To put it more correctly, we clogged our Travis-CI fair use share (accounted on dlang), by slowing down dmd by ~1.5x and then doubling the tests by adding 32-bit. As you see from the response times, reducing our test times to an acceptable level fixed that. |
Let's not rush this PR and wait how we resolve visibility of private members in meta code. |
|
Think this can be closed now, the next release will allow getMember to pass visibility checks. Access checks for getMember will be dropped in a later release (though likely are marked unsafe). |
|
alrighty |
|
@andralex did you mean to reopen it? It sounded like you were agreeing with closing it :) |
|
sorry! |
Due to more strict accessibility rules,
getSymbolsByUDAcan no longerreturn non-public members, as they are not visible to
std.traits.See discussion in #3827.