Skip to content

Avoid deprecation warning from getSymbolsByUDA. #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rcorre wants to merge 1 commit into from
Closed

Avoid deprecation warning from getSymbolsByUDA. #4724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions std/traits.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6886,24 +6886,26 @@ template getUDAs(alias symbol, alias attribute)
* Gets all symbols within `symbol` that have the given user-defined attribute.
* This is not recursive; it will not search for symbols within symbols such as
* nested structs or unions.
* This only returns members that are publically accessible.
*/
template getSymbolsByUDA(alias symbol, alias attribute) {
template getSymbolsByUDA(alias symbol, alias attribute)
{
import std.format : format;
import std.meta : AliasSeq, Filter;
import std.meta : AliasSeq, Filter, staticMap;

// translate a list of strings into symbols.
alias toSymbol(string name) = AliasSeq!(__traits(getMember, symbol, name));

// translate a list of strings into symbols. mixing in the entire alias
// avoids trying to access the symbol, which could cause a privacy violation
template toSymbols(names...) {
static if (names.length == 0)
alias toSymbols = AliasSeq!();
template hasSpecificUDA(string name)
{
static if (__traits(compiles, __traits(getMember, symbol, name)))
enum hasSpecificUDA = hasUDA!(__traits(getMember, symbol, name), attribute);
else
mixin("alias toSymbols = AliasSeq!(symbol.%s, toSymbols!(names[1..$]));"
.format(names[0]));
enum hasSpecificUDA = false;
}

enum hasSpecificUDA(string name) = mixin("hasUDA!(symbol.%s, attribute)".format(name));

alias membersWithUDA = toSymbols!(Filter!(hasSpecificUDA, __traits(allMembers, symbol)));
alias membersWithUDA = staticMap!(toSymbol,
Filter!(hasSpecificUDA, __traits(allMembers, symbol)));

// if the symbol itself has the UDA, tack it on to the front of the list
static if (hasUDA!(symbol, attribute))
Expand Down Expand Up @@ -6981,10 +6983,11 @@ template getSymbolsByUDA(alias symbol, alias attribute) {
@safe unittest
{
// HasPrivateMembers has, well, private members, one of which has a UDA.
// The presence private members should not cause an error, but will not be
// exposed by getSymbolsByUDA.
import std.internal.test.uda : Attr, HasPrivateMembers;
static assert(getSymbolsByUDA!(HasPrivateMembers, Attr).length == 2);
static assert(getSymbolsByUDA!(HasPrivateMembers, Attr).length == 1);
static assert(hasUDA!(getSymbolsByUDA!(HasPrivateMembers, Attr)[0], Attr));
static assert(hasUDA!(getSymbolsByUDA!(HasPrivateMembers, Attr)[1], Attr));
}

/**
Expand Down