Fix link format for changes in PR 4940 (std.numeric.gcd)#4951
Fix link format for changes in PR 4940 (std.numeric.gcd)#4951wilzbach wants to merge 1 commit intodlang:masterfrom
Conversation
| or $(HTTPS en.wikipedia.org/wiki/Binary_GCD_algorithm, Stein's) algorithm. | ||
| an efficient algorithm such as $(LINK2 en.wikipedia.org/wiki/Euclidean_algorithm, Euclid's) | ||
| or $(LINK2 en.wikipedia.org/wiki/Binary_GCD_algorithm, Stein's) algorithm. | ||
| */ |
There was a problem hiding this comment.
This patch is wrong, you need to add the protocol if you change the macro away from HTTP/HTTPS.
|
I don't mean to antagonize but please let's let this go. Thanks. |
|
Actually I might be missing something - was there a problem with the way links were previously generated? |
|
Ah damn - I just read the PR mail on my phone and didn't realize that the change was already part of the PR. (there's the bigger discussion of deprecating HTTP/HTTPS in favor of LINK2, but that's another day) |
|
@wilzbach an epic discussion is occurring right now on irc |
|
@wilzbach @aG0aep6G Andrei and I had a quick debate on IRC about HTTP/HTTPS vs. LINK2 & co. and one strong argument in favor of HTTP/HTTPS is DDoc's special handling handling of : (i.e. when the URL starts at the beginning of the line). When text is rewrapped in the editor this can put the URL at the beginning of the line, which spontaneously breaks links. An idea we came to is to change DMD's DDoc parsing to treat |
|
The perils of having reinvented source code documentation format... ;) |
I'm aware of that argument. I think it's rather weak, because HTTP/HTTPS still fail when the comment is indented somehow, which is common.
Old news ;) Sounds good to me, obviously. |
|
FWIW I don't indent documentation. |
|
@MartinNowak which one are you referring to at the time ddoc was introduced? |
Yes, you do: phobos/std/experimental/checkedint.d Lines 195 to 197 in 85fcd4a |
Fixup for #4940, which was merged prematurely :/