Skip to content

fix bad url in std-file-readText.dd#6226

Merged
wilzbach merged 1 commit intodlang:masterfrom
timotheecour:pr_fix_changelog_readtext
Feb 27, 2018
Merged

fix bad url in std-file-readText.dd#6226
wilzbach merged 1 commit intodlang:masterfrom
timotheecour:pr_fix_changelog_readtext

Conversation

@timotheecour
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @timotheecour! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.


$(REF readText, std, file) now checks for a
$(HTTP https://en.wikipedia.org/wiki/Byte_order_mark, BOM). If a BOM is present
$(HTTPS en.wikipedia.org/wiki/Byte_order_mark, BOM). If a BOM is present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we phase out this entire HTTP/HTTPS non-sense, and just use LINK2, but Andrei has been against this in the past.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking down links like that is UGLY and contrary to having readable docs when they're un-rendered (eg we can't simply copy paste these links to/from a browser); and it's error prone as examplified here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also:

#4411 (comment)
#4951 (comment)

In short:

  • at least there's WEB anymore
  • The Ddoc issue has been fixed, so in theory we could try this again, but I'm not sure whether it's worth the pain.

Though maybe we can can @andralex's approval this time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing https:// is awkward and integrating it in a macro is sensible. We could and should fix matters on the ddoc side; the issue of line breakage in macros is not singular to this one. Until then please leave HTTP and HTTPS where they are. Thanks.

@wilzbach wilzbach merged commit bc05618 into dlang:master Feb 27, 2018
@wilzbach
Copy link
Contributor

Merged manually due to braddr/d-tester#70

@timotheecour timotheecour deleted the pr_fix_changelog_readtext branch February 27, 2018 21:46
MartinNowak added a commit to MartinNowak/dlang.org that referenced this pull request Mar 2, 2018
- did not land in generated changelog as that is generated from stable
  (see dlang/phobos#6199 and dlang/phobos#6226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants