fix bad url in std-file-readText.dd#6226
Conversation
|
Thanks for your pull request and interest in making D better, @timotheecour! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
|
||
| $(REF readText, std, file) now checks for a | ||
| $(HTTP https://en.wikipedia.org/wiki/Byte_order_mark, BOM). If a BOM is present | ||
| $(HTTPS en.wikipedia.org/wiki/Byte_order_mark, BOM). If a BOM is present |
There was a problem hiding this comment.
Ideally we phase out this entire HTTP/HTTPS non-sense, and just use LINK2, but Andrei has been against this in the past.
There was a problem hiding this comment.
breaking down links like that is UGLY and contrary to having readable docs when they're un-rendered (eg we can't simply copy paste these links to/from a browser); and it's error prone as examplified here
There was a problem hiding this comment.
See also:
#4411 (comment)
#4951 (comment)
In short:
- at least there's
WEBanymore - The Ddoc issue has been fixed, so in theory we could try this again, but I'm not sure whether it's worth the pain.
Though maybe we can can @andralex's approval this time?
There was a problem hiding this comment.
Typing https:// is awkward and integrating it in a macro is sensible. We could and should fix matters on the ddoc side; the issue of line breakage in macros is not singular to this one. Until then please leave HTTP and HTTPS where they are. Thanks.
|
Merged manually due to braddr/d-tester#70 |
- did not land in generated changelog as that is generated from stable (see dlang/phobos#6199 and dlang/phobos#6226)
No description provided.