Update std.traits to reflect renaming of TypeTuple to AliasSeq by wilzbach · Pull Request #4954 · dlang/phobos

wilzbach · 2016-12-13T07:05:30Z

Revived #3756 as is (just rebased to latest Master).

… terminology changed imports to use std.meta i.o. std.typetuple rename names ending in "Tuple" or "List" by using plural of preceding word or replacing by Seq. rename unclear names "Parameters" and "Fields" to refer to "Types" since we have "Identifiers" of the same also. add deprecated tags to all aliases referring to the old names in all cases above. add deprecated tags to the typetuple module and alias. changed references to "function" to "callable" wherever the template was testing for isCallable. move description of callable to "isCallable" only. minor typo corrections.

wilzbach · 2016-12-13T07:38:16Z

std/traits.d

 template SharedConstOf(T) { alias SharedConstOf = shared(const(T)); }
-/// ditto.
 template ImmutableOf(T)   { alias ImmutableOf   =    immutable(T) ; }



does anyone know what @jamadagni was trying to do here?
AFAICT this change undocuments all these templates, doesn't it?

I'd say undo this change

wilzbach · 2016-12-13T07:47:39Z

So I took #3756 as is (well apart from the necessary changes during the rebase) and started to amend my changes. The two important ones:

fixed compilation (thanks @tsbockman)
added deprecation messages and a specific date to the deprecated alias

andralex · 2016-12-13T20:44:52Z

dat copyright year update

andralex · 2016-12-13T20:45:44Z

What's Jenkins unhappy about?

wilzbach · 2016-12-13T23:32:36Z

dat copyright year update

There are (a lot) more changes - you need to click on "Load diff" ;-)

What's Jenkins unhappy about?

Martin just started the project tester. However many of the projects are still broken with the current DMD / Phobos. So please ignore it for now.

andralex

This seems to be a pass that someone made through a personal project after finding a nicer naming convention. I think it breaks too many things for too little benefit.

I think some of the things can be cherry picked, e.g. name of nodes in the grammar. Looks like a long task, thanks for taking it.

andralex · 2016-12-13T23:45:18Z

std/traits.d

 * ))
 * $(TR $(TD Type behaviours) $(TD
 *           $(LREF isAbstractClass)
 *           $(LREF isAbstractFunction)
+ *           $(LREF isInstanceOf)


why did you move this? I think it was ordered alphabetically

andralex · 2016-12-13T23:46:09Z

std/traits.d

 *           $(LREF isFinalClass)
 *           $(LREF isFinalFunction)
 *           $(LREF isFunctionPointer)
- *           $(LREF isInstanceOf)
+ *           $(LREF isSomeFunction)


keep ordered

andralex · 2016-12-13T23:46:55Z

std/traits.d

 *           $(LREF Unqual)
+ *           $(LREF Signed)


this wasn't ordered but probably should

andralex · 2016-12-13T23:47:11Z

std/traits.d

@@ -146,7 +146,7 @@
 * Copyright: Copyright Digital Mars 2005 - 2009.
 * License:   $(HTTP www.boost.org/LICENSE_1_0.txt, Boost License 1.0).


andralex · 2016-12-13T23:47:33Z

std/traits.d

@@ -146,7 +146,7 @@
 * Copyright: Copyright Digital Mars 2005 - 2009.
 * License:   $(HTTP www.boost.org/LICENSE_1_0.txt, Boost License 1.0).
 * Authors:   $(HTTP digitalmars.com, Walter Bright),
- *            Tomasz Stachowiak ($(D isExpressions)),
+ *            Tomasz Stachowiak ($(D isExpressionSeq)),


Use backticks since you touched it?

andralex · 2016-12-13T23:48:39Z

std/traits.d

 template SharedConstOf(T) { alias SharedConstOf = shared(const(T)); }
-/// ditto.
 template ImmutableOf(T)   { alias ImmutableOf   =    immutable(T) ; }



I'd say undo this change

andralex · 2016-12-13T23:49:14Z

std/traits.d

 */
-template Parameters(func...)
+template ParameterTypes(func...)


Is this a breaking change?

andralex · 2016-12-13T23:50:01Z

std/traits.d

 }

 @safe unittest
 {
-    alias STC = ParameterStorageClass;
+    alias PSC = ParameterStorageClass;


this kind of thing seems gratuitous

andralex · 2016-12-13T23:51:23Z

std/traits.d

+
+// @@@DEPRECATED_2017-12@@@
+deprecated("It will be removed from Phobos in December 2017. Use ParameterTypes")
+alias Parameters = ParameterTypes;


this seems gratuitous

andralex · 2016-12-13T23:51:46Z

std/traits.d

    else
        static assert(0, "argument has no parameters");
 }

+// @@@DEPRECATED_2017-12@@@
+deprecated("It will be removed from Phobos in December 2017. Use ParameterTypes")
+alias ParameterTypeTuple = ParameterTypes;


this seems something we can live with

wilzbach · 2016-12-19T08:13:45Z

This seems to be a pass that someone made through a personal project after finding a nicer naming convention. I think it breaks too many things for too little benefit.

I think some of the things can be cherry picked, e.g. name of nodes in the grammar. Looks like a long task, thanks for taking it.

Okay started with the least controversial bit: triggering the deprecation warnings for std.typetuple -> #4968

andralex · 2016-12-19T13:48:11Z

@MartinNowak - I think you should look at this.

wilzbach · 2017-05-12T13:09:57Z

Closing this for the same reason as #4968 (not much time, no progress / consensus in sight).
However, as mentioned on the other PR I am still interested in seeing this happening, so @ D enthusiasts from the future please don't take this as a sign, that we will never clean up the mess std.typetuple, just don't give up trying ;-)

jamadagni added 3 commits December 13, 2016 08:00

std.traits: replace all instances of TypeTuple with AliasSeq

00f5a27

std.traits: other minor cleanups for better readability

a586519

wilzbach mentioned this pull request Dec 13, 2016

Update std.traits to reflect renaming of TypeTuple to AliasSeq #3756

Closed

wilzbach added 3 commits December 13, 2016 08:15

proper deprecation warnings

7366e75

markdownify DPARAM

1cda996

Set proper deprecation messages and fix compilation

cdd072f

wilzbach commented Dec 13, 2016

View reviewed changes

Fix Phobos style

a2cd07d

andralex approved these changes Dec 13, 2016

View reviewed changes

andralex requested changes Dec 13, 2016

View reviewed changes

wilzbach mentioned this pull request Dec 19, 2016

Deprecate std.typetuple #4968

Closed

andralex assigned MartinNowak Dec 19, 2016

wilzbach closed this May 12, 2017

wilzbach mentioned this pull request Feb 27, 2018

Continue renaming std.traits.*Tuple as per #3264 #6227

Closed

		@@ -146,7 +146,7 @@
		* Copyright: Copyright Digital Mars 2005 - 2009.
		* License: $(HTTP www.boost.org/LICENSE_1_0.txt, Boost License 1.0).

Uh oh!

Conversation

wilzbach commented Dec 13, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Dec 13, 2016

Uh oh!

andralex commented Dec 13, 2016

Uh oh!

andralex commented Dec 13, 2016

Uh oh!

wilzbach commented Dec 13, 2016

Uh oh!

andralex left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Dec 19, 2016

Uh oh!

andralex commented Dec 19, 2016

Uh oh!

wilzbach commented May 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants