Continue renaming std.traits.*Tuple as per #3264#6227
Continue renaming std.traits.*Tuple as per #3264#6227ntrel wants to merge 1 commit intodlang:masterfrom
Conversation
Add legacy aliases. * ParameterIdentifierTuple -> *ParameterNames* (consistency with FieldNames) * ParameterStorageClassTuple -> ParameterStorageClasses * BaseClassesTuple -> BaseClasses * BaseTypeTuple -> BaseTypes * InterfacesTuple -> *BaseInterfaces* * FieldNameTuple -> FieldNames * MemberFunctionsTuple -> *MemberOverloads* (more precise) * RepresentationTypeTuple -> RepresentationTypes * TransitiveBaseTypeTuple -> TransitiveBaseTypes * isTypeTuple -> isTypes
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
This needs a changelog entry. Also, I'd argue that deprecations should be added onto these aliases. Any objections? |
|
They probably weren't deprecated back in 2015 because we weren't as worried about breaking code. I agree with @JackStouffer. |
I tried to revive this too: #4954 Andrei closed it with:
So yeah, it looks like we can't deprecate the aliases, but imho we should still do the renames. BTW there was also #4968 which didn't get any interest at that time. |
|
No more grand renamings please. |
|
Well, since Andrei is in charge of names I think it's safe to close this. |
|
Would this be appropriate for |
Continue renaming of templates resolving to a sequence, but are named as
*Tuple.Some new names don't follow the pattern (shown in italic):
isExpressionTuple->isExpressionschange)As #3264 didn't deprecate the legacy aliases, I haven't done so either. BTW that pull did make the following changes, which I think are inaccurate:
I would prefer those aliases were ParameterTypes and FieldTypes. Mentioning now as it may be a good time to fix those too.