Closed
Conversation
I don't know why this seems to work for DMD. LDC failed to compile the unittests for this module. Firstly, `alias std.regex.internal.kickstart.Kickstart = std.regex.internal.kickstart.ShiftOr` wasn't found. That seems okay, as std.regex.internal.kickstart is only imported locally in a struct in imported std.regex.internal.ir. When working around that, LDC complained that class std.regex.internal.**shiftor**.ShiftOr can't derive from **struct** std.regex.internal.**kickstart**.ShiftOr. When fixing that by not deriving from anything (there was a std.regex.internal.ir.Kickstart interface before dlang/phobos@5a2491a), further compile errors arised as one can't foreach over a CodepointSet directly. I patched the problematic sites via copying code from the almost identical struct Kickstart in module kickstart, so that it now really works.
Contributor
Author
|
Hmm, no way to retrigger CI after fixing the base branch? |
Contributor
Author
|
Opening a new PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why this seems to work for DMD. LDC failed to compile the unittests for this module.
Firstly,
alias std.regex.internal.kickstart.Kickstart = std.regex.internal.kickstart.ShiftOrwasn't found. That seems okay, as std.regex.internal.kickstart is only imported locally in a struct in imported std.regex.internal.ir.When working around that, LDC complained that class std.regex.internal.shiftor.ShiftOr can't derive from struct std.regex.internal.kickstart.ShiftOr.
When fixing that by not deriving from anything (there was a std.regex.internal.ir.Kickstart interface before 5a2491a), further compile errors arised as one can't foreach over a CodepointSet directly. I patched the problematic sites via copying code from the almost identical struct Kickstart in module kickstart, so that it now really works.