Remove orphaned std.regex.internal.shiftor#5244
Conversation
|
auto-tester and DAutoTest seem to reuse the cached results for the same commit wrongly targeting branch |
This seems scary. It smells like botched merge but I astonished it doesn't cause any problems so far. |
The |
|
So it seems like the fix for |
|
It really appears to be an accidental remainder from the reverted regex overhaul (?); the |
Apparently a leftover from dlang/phobos@5a2491a. Not included in the makefile and not compilable either.
kinke
changed the title
|
(File removed. CI problems should be unrelated.) |
|
Auto-merge toggled on |
|
@MartinNowak: FYI – shouldn't have any impact on coming point releases, though, as the file wasn't listed in the dlang/phobos makefiles in the first place. |
|
@kinke The doc builder error is an error that was fixed here dlang/dlang.org#1568 I don't know why it's manifesting again. |
|
Somebody please retrigger CircleCI manually, I can't... |
|
Rebuild started. |
|
Yeah, it's some weird error on circle. CC @wilzbach |
|
Auto-merge toggled off |
|
Auto-merge toggled on |
4 participants
I don't know why this seems to work for DMD. LDC failed to compile the unittests for this module.
Firstly,
alias std.regex.internal.kickstart.Kickstart = std.regex.internal.kickstart.ShiftOrwasn't found. That seems okay, as std.regex.internal.kickstart is only imported locally in a struct in imported std.regex.internal.ir.When working around that, LDC complained that class std.regex.internal.shiftor.ShiftOr can't derive from struct std.regex.internal.kickstart.ShiftOr.
When fixing that by not deriving from anything (there was a std.regex.internal.ir.Kickstart interface before 5a2491a), further compile errors arised as one can't foreach over a CodepointSet directly. I patched the problematic sites via copying code from the almost identical struct Kickstart in module kickstart, so that it now really works (for LDC at least).