Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
commented
Dec 15, 2017
| name: Install gdb | ||
| - run: | ||
| command: ./.circleci/run.sh style_lint | ||
| name: Run code style & linter |
Contributor
Author
There was a problem hiding this comment.
Currently I get the following:
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
core.exception.OutOfMemoryError@src/core/exception.d(702): Memory allocation failed
----------------
[Inferior 1 (process 2163) exited with code 01]
No stack.
See also: https://circleci.com/gh/wilzbach/phobos/13
Sadly gdb doesn't forward the exit code, it's apparently a well-known bug.
PetarKirov
reviewed
Dec 16, 2017
.circleci/config.yml
Outdated
| - checkout | ||
| - run: | ||
| command: cat /proc/meminfo | ||
| name: OS information |
Member
There was a problem hiding this comment.
Can you also try cat /sys/fs/cgroup/memory/memory.limit_in_bytes?
Contributor
Author
|
@ZombineDev asked me to print |
Contributor
Author
|
Contributor
Author
|
I logged in via ssh and added |
wilzbach
commented
Dec 17, 2017
|
|
||
| @echo "Check that Ddoc runs without errors" | ||
| $(DMD) $(DFLAGS) -defaultlib= -debuglib= $(LIB) -w -D -Df/dev/null -main -c -o- $$(find etc std -type f -name '*.d') 2>&1 | grep -v "Deprecation:"; test $$? -eq 1 | ||
| $(DMD) $(DFLAGS) -defaultlib= -debuglib= $(LIB) -w -D -Df/dev/null -main -c -o- $$(find etc std -type f -name '*.d') 2>&1 |
Contributor
Author
There was a problem hiding this comment.
DMD built in debug mode always prints: DMD v2.077.1 DEBUG on startup, hence the fragile grep failed.
Contributor
Author
|
So I now get the same stack traces as on CircleCi 1.0: |
Contributor
Author
|
@ZombineDev or others: how about moving forward with this?
|
PetarKirov
approved these changes
Dec 17, 2017
| build: | ||
| working_directory: ~/phobos | ||
| docker: | ||
| - image: circleci/node:4.8.2 |
Member
There was a problem hiding this comment.
Looking forward to replacing this with our custom image ;)
This was referenced Dec 18, 2017
Member
|
Interesting, indeed we should use our own build images to leverage caching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks fairly straight-forward so far.
Note that CircleCi 2.0 allows to use custom Docker images.
So for example, we could built the DMD compiler into it and avoid the network issues during it's download.
Also allows this other customization, e.g. sth. like @ZombineDev's PIE-hardened docker images (https://github.com/ZombineDev/dmd-test-suite-docker) to run all testsuites on a PIE-hardened system.