Skip to content

Comments

Merge remote-tracking branch 'upstream/stable' into merge_stable#5944

Merged
dlang-bot merged 3 commits intodlang:masterfrom
MartinNowak:merge_stable
Dec 18, 2017
Merged

Merge remote-tracking branch 'upstream/stable' into merge_stable#5944
dlang-bot merged 3 commits intodlang:masterfrom
MartinNowak:merge_stable

Conversation

@MartinNowak
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor

CircleCi failure is due to #5930 -> will rebase this PR.

Dashster and others added 3 commits December 18, 2017 17:05
 $(TR $(TD $(LREF OutputRangeObject))
        $(TD Class that implements the $(D OutputRange) interface and wraps the
        $(D put) methods in virtual functions.
*************************************************************
    ))   <-   add the missing ending double parentheses
***************************************************************
@dlang-bot dlang-bot merged commit a79876f into dlang:master Dec 18, 2017
@MartinNowak MartinNowak deleted the merge_stable branch December 18, 2017 22:45
@MartinNowak
Copy link
Member Author

Please don't rebase merge commits. Loosing the parent information does easily cause merge conflicts.
Doesn't circleci merge with master before reading it's yaml file?

@wilzbach
Copy link
Contributor

Please don't rebase merge commits. Loosing the parent information does easily cause merge conflicts.

Sorry.

Doesn't circleci merge with master before reading it's yaml file?

No, we merge ourselves and with 2.0 the location of the config file changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants