Skip to content

Comments

Fix erroneous imports#6048

Merged
andralex merged 1 commit intodlang:masterfrom
RazvanN7:Issue_17630
Jan 22, 2018
Merged

Fix erroneous imports#6048
andralex merged 1 commit intodlang:masterfrom
RazvanN7:Issue_17630

Conversation

@RazvanN7
Copy link
Collaborator

This currently blocks : dlang/dmd#7760

@RazvanN7 RazvanN7 requested a review from PetarKirov as a code owner January 22, 2018 14:32
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.


import std.typecons : Tuple, tuple, Bind, DerivedFunctionType,
isImplicitlyConvertible, mixinAll, staticIota,
import std.typecons : Tuple, tuple, Bind, DerivedFunctionType, mixinAll, staticIota,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can even remove mixinAll + staticIota entirely -> #6049

@andralex
Copy link
Member

Will force merge in the interest of time.

@andralex andralex merged commit 617f6b0 into dlang:master Jan 22, 2018
@wilzbach
Copy link
Contributor

Will force merge in the interest of time.

While I like the enthusiasm and action, I think it would be best of force merge is only used if absolutely necessary, a criteria not fulfilled by this PR:

  1. It would have been merged in ~20 mins anyways:

image

  1. Fix Issue 17630 - selective imports find symbols in private imports o… dmd#7760 needs to be changed to emit deprecations anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants