Skip to content

Comments

Fix erroneous imports in unittests#6057

Merged
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:Fix_imports
Jan 23, 2018
Merged

Fix erroneous imports in unittests#6057
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:Fix_imports

Conversation

@RazvanN7
Copy link
Collaborator

This is part 2 of #6048 and is currently blocking : dlang/dmd#7760 because deprecations are treated as errors.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

}
}

public import core.sys.posix.netinet.in_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh - this is needed because the Windows branch is public import core.sys.windows.winsock2;

///
@safe unittest
{
import std.experimental.logger.nulllogger : LogLevel;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be import std.experimental.logger.core : LogLevel; instead

@RazvanN7
Copy link
Collaborator Author

The fail in jenkins seems unrelated. @atilaneves does this affect your project?

@atilaneves
Copy link
Contributor

@RazvanN7 I think that's a spurious error that has to do with an stdio bug. I'm confident that if rerun it'll be green.

@RazvanN7
Copy link
Collaborator Author

RazvanN7 commented Jan 23, 2018

@atilaneves ok. thanks! can you readd the auto-merge label please?

@dlang-bot dlang-bot merged commit ea1aa71 into dlang:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants