Fix erroneous imports in unittests#6057
Conversation
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
| } | ||
| } | ||
|
|
||
| public import core.sys.posix.netinet.in_; |
There was a problem hiding this comment.
Argh - this is needed because the Windows branch is public import core.sys.windows.winsock2;
| /// | ||
| @safe unittest | ||
| { | ||
| import std.experimental.logger.nulllogger : LogLevel; |
There was a problem hiding this comment.
This needs to be import std.experimental.logger.core : LogLevel; instead
|
The fail in jenkins seems unrelated. @atilaneves does this affect your project? |
|
@RazvanN7 I think that's a spurious error that has to do with an stdio bug. I'm confident that if rerun it'll be green. |
|
@atilaneves ok. thanks! can you readd the auto-merge label please? |
This is part 2 of #6048 and is currently blocking : dlang/dmd#7760 because deprecations are treated as errors.