Skip to content

Remove duplicate of anySatisfy implementation#6763

Merged
dlang-bot merged 1 commit intodlang:masterfrom
edi33416:reduce_anySatisfy
Nov 14, 2018
Merged

Remove duplicate of anySatisfy implementation#6763
dlang-bot merged 1 commit intodlang:masterfrom
edi33416:reduce_anySatisfy

Conversation

@edi33416
Copy link
Contributor

druntime's core.internal.traits.anySatisfy is a copy of the same code. This PR removes the code duplication and the required double maintenance of anySatisfy.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6763"

@nordlow
Copy link
Contributor

nordlow commented Nov 14, 2018

I presume that the druntime versions of these traits will use my recent additions to anySatisfy and allSatisfy making them iterative and thereby faster and less memory hungry via static foreach.

@n8sh
Copy link
Member

n8sh commented Nov 14, 2018

@nordlow Yup: dlang/druntime#2338

Copy link
Member

@n8sh n8sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per #6761 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants