Makefiles: Enable -checkaction-context for unittest builds

[MoonlightSentinel]

See dlang/druntime#2836.

Blocked by

• Fix Issue 20353 - -checkaction=context does not work well with const … dmd#10535
• Fix Issue 20375 - RefCounted does not work with checkaction-context dmd#10550
• Fix Issue 7619 - Infer deprecated for template instances dmd#10677
• Fix Issue 20581 - DIP1000 wrongly flags hidden ref temporary dmd#12258

[MoonlightSentinel]

Some more DIP1000 issues in std.range:

void main() @safe
{
    int[5] a = [ 1, 2, 3, 4, 5 ];
    assert(retro(a[]).source is a[]);
}

auto retro(return scope int[] s) @safe
{
    static struct R
    {
        int[] source;
    }
    return R(s);
}

safe.d(6): Error: address of variable a assigned to __assertOp4 with longer lifetime

---

https://issues.dlang.org/show_bug.cgi?id=20581

[RazvanN7]

@MoonlightSentinel This seems to pass all the tests now. Does this still depend on dlang/dmd#10677 ?

[MoonlightSentinel]

Not ATM, but there could be new problems if another deprecated type is used in an assert.

Also there is still a potential for linker errors due to missing template instances (because Druntime and Phobos are compiled without -checkaction=context). That's why -checkaction=D is currently required for the publictest target.

[RazvanN7]

How should we move forward? Should we merge this or should we first merge dlang/dmd#10677 and compile druntime and dmd with checkaction=context ?

[MoonlightSentinel]

I'll close this PR for now, it has caught all remaining issues with -checkaction=context in Phobos.

We can gradually enable -checkaction=context for druntime/phobos once it get around to finish dlang/dmd#10677.