Makefiles: Enable -checkaction-context for unittest builds

[MoonlightSentinel]

Build unittests with informative assert messages to improve the CI logs and ease bug hunting (inspired by dlang/phobos#7222).

Draft PR as this revealed some bugs in the implementation of -checkaction=context:

• Fix Issue 20315 - checkaction=context fails for const(void[]) argument #2837
• Fix Issue 20322 - checkaction=context fails for wstring/dstring arguments #2840
• Fix Issue 20323 - checkaction=context fails for non-copyable arguments #2841
• Fix Issue 20326 - stringof on opaque type results in forward referenc… dmd#10511
• (Issue 20114 - -checkaction=context evaluates operand second time on a… dmd#10512)
• Issue 20331 - checkaction=context segfaults when calling function lit… dmd#10513
• Fix Issue 20346 - std.uuid does not compile with checkaction=context #2846
• Fix Issue 20353 - -checkaction=context does not work well with const … dmd#10535

CC @burner

[wilzbach]

Yeah, I am not sure -checkaction=context is ready for this yet. Anyhow, the error that you're getting is due druntime now being build with -checkaction=context as well and thus build errors:

src/core/lifetime.d(1565):        instantiated from here: `_d_assert_fail!("is", S5, S5)`

[wilzbach]

BTW @MoonlightSentinel please feel free to send me a ping if you want to be part of the DLang Slack. It's often more efficient to talk there ;-)

[MoonlightSentinel]

I am not sure -checkaction=context is ready for this yet. Anyhow, the error that you're getting is due druntime now being build with -checkaction=context as well and thus build errors:

src/core/lifetime.d(1565):        instantiated from here: `_d_assert_fail!("is", S5, S5)`

Agreed, but testing this feature on a large codebase (druntime/phobos) seems useful to flush out any remaining bugs (hence the draft PRs)

BTW @MoonlightSentinel send me a ping if you want to be part of the DLang Slack. It's often more efficient to talk there ;-)

@wilzbach Like this? (Sorry, first 'real' GitHub project)

[wilzbach]

Agreed, but testing this feature on a large codebase (druntime/phobos) seems useful to flush out any remaining bugs (hence the draft PRs)

👍

@wilzbach Like this? (Sorry, first 'real' GitHub project)

Well, I was more asking for a quick email (sorry for not being clearer). Anyhow, I was just asking for your consent because I didn't want to send things to your email address without asking.
The Slack room is somewhat semi-public. We can't make it fully public because there's a limit on the # of people we can have there, but on the other hand that helps the noise:info ratio compared to the NG.
Anyhow, happy chatting!

[MoonlightSentinel]

Well, I was more asking for a quick email (sorry for not being clearer). Anyhow, I was just asking for your consent because I didn't want to send things to your email address without asking.

Thanks!

The Slack room is somewhat semi-public. We can't make it fully public because there's a limit on the # of people we can have there, but on the other hand that helps the noise:info ratio compared to the NG.
Anyhow, happy chatting!

Seems reasonable

[MoonlightSentinel]

There are two remaining failures which I cannot reproduce locally but seem to occur reliable on the CI systems:

• dmd/backend/symbol.d:1170: Assertion '(*s).Ssymnum == -1' failed. [auto-tester (windows) and buildkite]

Verbose output lists function rt.util.container.array.__unittest_L143_C1 as the current task when hitting the assert.

• ThreadError in test/gc/sigmaskgc.d [Circle CI]

Testing sigmaskgc
./generated/linux/debug/64/sigmaskgc
uncaught exception
core.thread.osthread.ThreadError@src/core/thread/osthread.d(3176): Unable to suspend thread
----------------
...
----------------
uncaught exception
core.thread.osthread.ThreadError@src/core/thread/osthread.d(3176): Unable to suspend thread
----------------
make[2]: Leaving directory '/home/circleci/druntime/test/gc'

Any suggestions?

[MoonlightSentinel]

Unittest builds using checktion=context pass the test suite on any plattform (without any of the aforementioned errors)!

[wilzbach]

Awesome work! Thank you very much!

[nordlow]

Keep up this awesome work!

Making -checkaction=context stable and non-disruptive for the remaining corner-cases will become a big selling point for D over most (all) other languages.