Fix Issue 20322 - checkaction=context fails for wstring/dstring arguments

[MoonlightSentinel]

This includes #2837 to avoid calling toUtf8 on ubye[]s, ... without excessive template constraints

[dlang-bot]

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20322	normal	checkaction=context fails for wstring/dstring arguments

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2840"

[PetarKirov]

I'm waiting for the CI on #2837 to pass, before so can merge it. Once those commits are in, you should rebase this PR and we can merge it.

[MoonlightSentinel]

@PetarKirov Thanks for doing the rebase, you were slightly faster than me

[PetarKirov]

You're welcome :) Thanks for your recent PRs, I hope I can keep up with reviewing them ;)

[MoonlightSentinel]

@PetarKirov buildkites dlang-tour/core fails but seems unrelated:

Running ./dlang-tour-test-library
--
lang: en, chapter: basics, section: ranges failed
source/contentprovider.d(328): [unittest] Source code line length exceeds 48 limit in 'Ranges':     auto fibEven = fib5.filter!(x => x % 2 == 0);
object.Exception@source/contentprovider.d(328): Source code line length exceeds 48 limit in 'Ranges':     auto fibEven = fib5.filter!(x => x % 2 == 0);
----------------
source/contentprovider.d:328 void contentprovider.ContentProvider.checkSourceCodeLineWidth(immutable(char)[], immutable(char)[]) [0x951940]
source/contentprovider.d:233 contentprovider.ContentProvider.Content* contentprovider.ContentProvider.addSection(immutable(char)[], immutable(char)[], immutable(char)[], immutable(char)[]) [0x950d5a]
source/contentprovider.d:201 int contentprovider.ContentProvider.addChapter(immutable(char)[], immutable(char)[], immutable(char)[]).__foreachbody5(ref immutable(char)[]) [0x95091f]
../.dub/packages/dyaml-0.7.1/dyaml/source/dyaml/node.d:1232 int dyaml.node.Node.opApply!(int delegate(ref immutable(char)[])).opApply(int delegate(ref immutable(char)[])) [0x95f962]
source/contentprovider.d:198 void contentprovider.ContentProvider.addChapter(immutable(char)[], immutable(char)[], immutable(char)[]) [0x950844]
source/contentprovider.d:185 int contentprovider.ContentProvider.addLanguage(immutable(char)[]).__foreachbody8(ref immutable(char)[]) [0x95063c]
../.dub/packages/dyaml-0.7.1/dyaml/source/dyaml/node.d:1232 int dyaml.node.Node.opApply!(int delegate(ref immutable(char)[])).opApply(int delegate(ref immutable(char)[])) [0x95f962]
source/contentprovider.d:181 void contentprovider.ContentProvider.addLanguage(immutable(char)[]) [0x950388]
source/contentprovider.d:285 void contentprovider.ContentProvider.__unittest_L281_C2() [0x95160f]
??:? void contentprovider.__modtest() [0x988db4]
??:? int core.runtime.runModuleUnitTests().__foreachbody2(object.ModuleInfo*) [0xc66c8c]
??:? int object.ModuleInfo.opApply(scope int delegate(object.ModuleInfo*)).__lambda2(immutable(object.ModuleInfo*)) [0xbfc0f3]
??:? int rt.minfo.moduleinfos_apply(scope int delegate(immutable(object.ModuleInfo*))).__foreachbody2(ref rt.sections_elf_shared.DSO) [0xc131ab]
??:? int rt.sections_elf_shared.DSO.opApply(scope int delegate(ref rt.sections_elf_shared.DSO)) [0xc13a00]
??:? int rt.minfo.moduleinfos_apply(scope int delegate(immutable(object.ModuleInfo*))) [0xc13139]
??:? int object.ModuleInfo.opApply(scope int delegate(object.ModuleInfo*)) [0xbfc0c5]
??:? runModuleUnitTests [0xc66ac9]
??:? void rt.dmain2._d_run_main2(char[][], ulong, extern (C) int function(char[][])*).runAll() [0xc0d788]
??:? void rt.dmain2._d_run_main2(char[][], ulong, extern (C) int function(char[][])*).tryExec(scope void delegate()) [0xc0d714]
??:? _d_run_main2 [0xc0d67d]
??:? _d_run_main [0xc0d439]
/var/lib/buildkite-agent/builds/ci-agent-4c8a3813-857a-4234-8127-eb48f8cae192-7/dlang/druntime/build/distribution/bin/../imports/core/internal/entrypoint.d:34 main [0x8c0f89]
??:? __libc_start_main [0x7f0cd0c2b82f]
hash1 = RunInput("test123", "dmd", "", "", false)
hash2 = RunInput("void main() {}", "dmd", "", "", false)
hash3 = RunInput("12838389349493", "dmd", "", "", false)
hash1 = 3567143320
hash2 = 602060069
hash3 = 2798006402
1/4 unittests FAILED
Program exited with code 1

[PetarKirov]

Yes, it's indeed unrelated. I'll merge this PR and fix the dlang-tour failure.

[PetarKirov]

Yes, it's indeed unrelated. I'll merge this PR and fix the dlang-tour failure.

Done, so dlang-tour is now green again.