Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20315 - checkaction=context fails for const(void[]) argument#2837

Merged
dlang-bot merged 2 commits intodlang:masterfrom
MoonlightSentinel:checkaction-voidarr
Oct 28, 2019
Merged

Fix Issue 20315 - checkaction=context fails for const(void[]) argument#2837
dlang-bot merged 2 commits intodlang:masterfrom
MoonlightSentinel:checkaction-voidarr

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

The old implementation checked only for mutable void[].
The diff is slightly larger because i joined the (void[]), (some string) and (some other slice) branches to avoid redundant type checks.

The second commit enables actual formatting for void[] as an array of bytes instead of omitting it.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20315 normal checkaction=context fails for const(void[]) argument

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2837"

@dlang-bot dlang-bot merged commit 242de2a into dlang:master Oct 28, 2019
@MoonlightSentinel MoonlightSentinel deleted the checkaction-voidarr branch October 28, 2019 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants