This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix Issue 20315 - checkaction=context fails for const(void[]) argument#2837
Merged
dlang-bot merged 2 commits intodlang:masterfrom Oct 28, 2019
Merged
Fix Issue 20315 - checkaction=context fails for const(void[]) argument#2837dlang-bot merged 2 commits intodlang:masterfrom
dlang-bot merged 2 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2837" |
This was referenced Oct 26, 2019
d4b6250 to
e8c942a
Compare
PetarKirov
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation checked only for mutable void[].
The diff is slightly larger because i joined the (void[]), (some string) and (some other slice) branches to avoid redundant type checks.
The second commit enables actual formatting for void[] as an array of bytes instead of omitting it.