UUID: Replace 'in ref' overloads with 'const scope ref'#7593
Merged
dlang-bot merged 1 commit intodlang:masterfrom Aug 15, 2020
Merged
UUID: Replace 'in ref' overloads with 'const scope ref'#7593dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
'in' and 'in ref' overloads will conflict in the future if dlang/dmd#11000 is accepted. Even if not, 'in' currently means something different based on a switch, however the intention of this code is obviously the full 'const scope'. In the some places, 'scope' was omitted as it is meaningless on value types.
Contributor
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7593" |
thewilsonator
approved these changes
Aug 15, 2020
kinke
added a commit
to kinke/phobos
that referenced
this pull request
Oct 31, 2020
Code compiled with -preview=in is currently supposed to link successfully against druntime/Phobos compiled without -preview=in. There were still a few places where -preview=in makes a difference for existing `in` params; convert them to `const [scope]`, analogous to PR dlang#7593.
dlang-bot
pushed a commit
that referenced
this pull request
Nov 1, 2020
Code compiled with -preview=in is currently supposed to link successfully against druntime/Phobos compiled without -preview=in. There were still a few places where -preview=in makes a difference for existing `in` params; convert them to `const [scope]`, analogous to PR #7593.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'in' and 'in ref' overloads will conflict in the future if dlang/dmd#11000 is accepted.
Even if not, 'in' currently means something different based on a switch,
however the intention of this code is obviously the full 'const scope'.
In the some places, 'scope' was omitted as it is meaningless on value types.