Minor fixes for -preview=in and targets preferring by-ref for real#7687
Minor fixes for -preview=in and targets preferring by-ref for real#7687dlang-bot merged 1 commit intodlang:masterfrom
real#7687Conversation
Code compiled with -preview=in is currently supposed to link successfully against druntime/Phobos compiled without -preview=in. There were still a few places where -preview=in makes a difference for existing `in` params; convert them to `const [scope]`, analogous to PR dlang#7593.
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7687" |
|
@kinke : Does that mean that LDC v1.24 is not compatible with |
|
I guess so, just like DMD 2.094[.1] isn't for targets with by-ref |
Code compiled with
-preview=inis currently supposed to link successfully against druntime/Phobos compiled without-preview=in.There were still a few places where
-preview=inmakes a difference for existinginparams; convert them toconst [scope], analogous to PR #7593.