Skip to content

Comments

Annotate std/file.d to please dlang/dmd#12520#8085

Merged
dlang-bot merged 1 commit intodlang:masterfrom
nordlow:fix-pure-scope-file
May 20, 2021
Merged

Annotate std/file.d to please dlang/dmd#12520#8085
dlang-bot merged 1 commit intodlang:masterfrom
nordlow:fix-pure-scope-file

Conversation

@nordlow
Copy link
Contributor

@nordlow nordlow commented May 16, 2021

Part of #8076

The #8107 and this PR are the two remaining Phobos blockers for dlang/dmd#12520.

@nordlow nordlow requested a review from CyberShadow as a code owner May 16, 2021 22:19
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @nordlow! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8085"

@nordlow nordlow changed the title Annotate std/file.d to please dlang/dmd#12520 WIP: Annotate std/file.d to please dlang/dmd#12520 May 16, 2021
@nordlow nordlow force-pushed the fix-pure-scope-file branch from 6590b15 to 0d23e83 Compare May 19, 2021 09:07
@nordlow

This comment has been minimized.

@nordlow nordlow requested a review from kyllingstad as a code owner May 19, 2021 13:01
@nordlow
Copy link
Contributor Author

nordlow commented May 19, 2021

make -f posix.mak unittest pass now using dlang/dmd#12520. Yay! Thanks, @MrSmith33.

Removed WIP in title. Squashed. Ready for review and auto-merge now.

Ping, @RazvanN7 @thewilsonator @dkorpel

@nordlow nordlow changed the title WIP: Annotate std/file.d to please dlang/dmd#12520 Annotate std/file.d to please dlang/dmd#12520 May 19, 2021
@nordlow nordlow force-pushed the fix-pure-scope-file branch 2 times, most recently from 79f9070 to 8629cfd Compare May 19, 2021 19:06
@nordlow
Copy link
Contributor Author

nordlow commented May 19, 2021

Does anybody know why Ubuntu 16.04 x86 and macOS 10.15 x64 fails? Restart?

@RazvanN7
Copy link
Collaborator

I restarted the failing tests. Let's see.

@dlang-bot dlang-bot merged commit 61d60d2 into dlang:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants