Skip to content

Comments

Annotate absolutePath in std/path.d to please dlang/dmd#12520#8107

Closed
nordlow wants to merge 0 commit intodlang:masterfrom
nordlow:fix-pure-scope-absolutePath
Closed

Annotate absolutePath in std/path.d to please dlang/dmd#12520#8107
nordlow wants to merge 0 commit intodlang:masterfrom
nordlow:fix-pure-scope-absolutePath

Conversation

@nordlow
Copy link
Contributor

@nordlow nordlow commented May 19, 2021

Follow-up to #8106 to see if the same linker-error triggered by #8090 happens again. IRC, the linker error was caused by picking a symbol with incorrect mangling of absolutePath.

As

echo _D3std4path12absolutePathFNaNfAyaLQeZQh | ddemangle

prints

pure @safe immutable(char)[] std.path.absolutePath(immutable(char)[], lazy immutable(char)[])

it seems the error was caused by the CI, for some unknown reason, not linking with the recently built version of phobos.

Previous try was reverted via #8103.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @nordlow! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8107"

@thewilsonator
Copy link
Contributor

cc @ibuclaw

@nordlow
Copy link
Contributor Author

nordlow commented May 19, 2021

Green now. Shall we try again, @ibuclaw?

@nordlow nordlow closed this May 20, 2021
@nordlow nordlow force-pushed the fix-pure-scope-absolutePath branch from 389d5ab to 61d60d2 Compare May 20, 2021 11:40
@nordlow
Copy link
Contributor Author

nordlow commented May 20, 2021

This annotation of absolutePath accidentally sneaked in via

https://github.com/dlang/phobos/pull/8085/files

. Sorry for that. Let's hope the previous linker error was intermittent. FYI, @ibuclaw

@nordlow nordlow deleted the fix-pure-scope-absolutePath branch October 19, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants