Annotate absolutePath in std/path.d to please dlang/dmd#12520#8107
Annotate absolutePath in std/path.d to please dlang/dmd#12520#8107nordlow wants to merge 0 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @nordlow! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8107" |
|
cc @ibuclaw |
|
Green now. Shall we try again, @ibuclaw? |
389d5ab to
61d60d2
Compare
|
This annotation of https://github.com/dlang/phobos/pull/8085/files . Sorry for that. Let's hope the previous linker error was intermittent. FYI, @ibuclaw |
Follow-up to #8106 to see if the same linker-error triggered by #8090 happens again. IRC, the linker error was caused by picking a symbol with incorrect mangling of
absolutePath.As
echo _D3std4path12absolutePathFNaNfAyaLQeZQh | ddemangleprints
pure @safe immutable(char)[] std.path.absolutePath(immutable(char)[], lazy immutable(char)[])it seems the error was caused by the CI, for some unknown reason, not linking with the recently built version of phobos.
Previous try was reverted via #8103.