Revert "Annotate std/path.d to please dlang/dmd#12520"

[ibuclaw]

Reverts #8090

Something broke master, and this is the only change that touches absolutePath.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8103"

[dkorpel]

What does the test output say? I can't find the broken commit.

[CyberShadow]

@dkorpel It's here:
#8092 (comment)

[ibuclaw]

Logs of #8092 are gone now, but also seen in:

• Annotate std/range/package.d to please dlang/dmd#12520 #8093 https://buildkite.com/dlang/phobos/builds/5499#cc42663b-941b-4eb7-90fe-276d34a6d1d3/472-3414
• Fix issue 21926 - Allow leadings zeros in std.conv.octal(string) #8077 https://buildkite.com/dlang/phobos/builds/5502#2536380c-2b57-4ba2-b58a-48dc21d29f98/471-3463

And a few others at the time.

generated/linux/release/64/benchmark.o:benchmark/runbench.d:function _D8runbench8runTestsFSQu6ConfigZv: error: undefined reference to '_D3std4path12absolutePathFNaNfAyaLQeZQh'
generated/linux/release/64/benchmark.o:benchmark/runbench.d:function _D8runbench8runTestsFSQu6ConfigZv: error: undefined reference to '_D3std4path12absolutePathFNaNfAyaLQeZQh'
collect2: error: ld returned 1 exit status
Error: linker exited with status 1

[dkorpel]

So void runbench.runTests(runbench.Config) can't find pure @safe immutable(char)[] std.path.absolutePath(immutable(char)[], lazy immutable(char)[]) because there's a new return annotation changing the mangle. Is the benchmark linking with new Phobos but importing old Phobos?

[nordlow]

How to move forward with this?

Here's a similar PR with the change to absolutePath excluded:
#8106

And then add a second PR with only the change to absolutePath?

[ibuclaw]

How to move forward with this?

Here's a similar PR with the change to absolutePath excluded:
#8106

And then add a second PR with only the change to absolutePath?

Seems reasonable to me.