Skip to content

Comments

Annotate std/range/package.d to please dlang/dmd#12520#8093

Merged
dlang-bot merged 1 commit intodlang:masterfrom
nordlow:fix-pure-scope-range
May 18, 2021
Merged

Annotate std/range/package.d to please dlang/dmd#12520#8093
dlang-bot merged 1 commit intodlang:masterfrom
nordlow:fix-pure-scope-range

Conversation

@nordlow
Copy link
Contributor

@nordlow nordlow commented May 17, 2021

Part of #8076

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @nordlow! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8093"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

Copy link
Collaborator

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind the doc typo

@nordlow nordlow force-pushed the fix-pure-scope-range branch from 6d9f9f5 to ef2cdc3 Compare May 17, 2021 12:50
@nordlow
Copy link
Contributor Author

nordlow commented May 17, 2021

Mind the doc typo

Done. Ready now.

@thewilsonator
Copy link
Contributor

removing automerge, druntime fails consistently. Maybe this needs stuff in stable?

@nordlow
Copy link
Contributor Author

nordlow commented May 18, 2021

removing automerge, druntime fails consistently. Maybe this needs stuff in stable?

Broken because of linker error triggered caused by now reverted #8103.

Rebasing to see if build passes again.

Ok to try auto-merge again, @RazvanN7.

@nordlow nordlow force-pushed the fix-pure-scope-range branch from ef2cdc3 to 4fc2882 Compare May 18, 2021 08:45
@dlang-bot dlang-bot merged commit 62d9ffb into dlang:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants