Skip to content

Add AppVeyor config file to test win32.mak#269

Merged
dlang-bot merged 3 commits intodlang:masterfrom
wilzbach:appveyor
Dec 22, 2017
Merged

Add AppVeyor config file to test win32.mak#269
dlang-bot merged 3 commits intodlang:masterfrom
wilzbach:appveyor

Conversation

@wilzbach
Copy link
Copy Markdown
Contributor

@wilzbach wilzbach commented Dec 7, 2017

Win rule untested!

-> let's add a CI to introduce light into the dark.

See also: dlang/installer#275

@dlang-bot
Copy link
Copy Markdown
Contributor

dlang-bot commented Dec 7, 2017

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach changed the title Add AppVeyor config file to test win32.mak [WIP] Add AppVeyor config file to test win32.mak Dec 7, 2017
@dlang-bot dlang-bot added the PR.WIP A pull request that's being worked on (use draft PR when possible) label Dec 7, 2017
@wilzbach wilzbach force-pushed the appveyor branch 3 times, most recently from 97da3eb to f3c1a30 Compare December 7, 2017 05:29
@wilzbach wilzbach changed the title [WIP] Add AppVeyor config file to test win32.mak Add AppVeyor config file to test win32.mak Dec 7, 2017
@wilzbach wilzbach removed the PR.WIP A pull request that's being worked on (use draft PR when possible) label Dec 7, 2017
@wilzbach wilzbach force-pushed the appveyor branch 2 times, most recently from 42bb51a to c43d1ed Compare December 7, 2017 05:32
wilzbach
wilzbach commented Dec 7, 2017
View reviewed changes
appveyor.yml Outdated
arch: x86
skip_tags: false
build_script:
- ps: wget https://raw.githubusercontent.com/wilzbach/installer/appveyor-script/script/install.ps1 -OutFile install.ps1
Copy link
Copy Markdown
Contributor Author

@wilzbach wilzbach Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be made official once dlang/installer#275 is merged, but works fine for now.

appveyor.yml Outdated
- echo %DC%
- echo %PATH%
- '%DC% --version'
- make -f win32.mak rdmd dustmite
Copy link
Copy Markdown
Contributor Author

@wilzbach wilzbach Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #265 is merged, we can also test all targets

@wilzbach wilzbach force-pushed the appveyor branch 2 times, most recently from 3b11d4b to 74eb207 Compare December 7, 2017 05:35
This was referenced Dec 10, 2017
Merged
Merged
MartinNowak
MartinNowak reviewed Dec 12, 2017
View reviewed changes
appveyor.yml Outdated
arch: x86
skip_tags: false
build_script:
- ps: wget https://raw.githubusercontent.com/wilzbach/installer/appveyor-script/script/install.ps1 -OutFile install.ps1
Copy link
Copy Markdown
Member

@MartinNowak MartinNowak Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, this is what I improvised in the mean time.
https://github.com/MartinNowak/io/blob/master/.appveyor.yml
Having a proper PowerShell install script would be great (https://stackoverflow.com/a/40491432/2371032).

Copy link
Copy Markdown
Member

@PetarKirov PetarKirov Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinNowak can we get dlang/installer#275 merged?

@MartinNowak MartinNowak mentioned this pull request Dec 13, 2017
Merged
@wilzbach wilzbach mentioned this pull request Dec 13, 2017
Merged
@wilzbach wilzbach force-pushed the appveyor branch 4 times, most recently from 8272c1c to ba700a7 Compare December 18, 2017 07:17
@wilzbach
Copy link
Copy Markdown
Contributor Author

wilzbach commented Dec 18, 2017

Okay as I don't think dlang/installer#275 will move anywhere in the next weeks, I inlined the important bits directly in the appveyor.yml, s.t. we can move forward here & finally start testing dlang/tools under Windows.
Next step: run the rdmd testsuite on Windows ...

@wilzbach
Copy link
Copy Markdown
Contributor Author

wilzbach commented Dec 21, 2017

CC @CyberShadow - are you okay with using AppVeyor here? I don't see any other easy option to test the tools repo under Windows.

@CyberShadow
Copy link
Copy Markdown
Member

CyberShadow commented Dec 22, 2017

Okay.

@dlang-bot dlang-bot merged commit 2d54424 into dlang:master Dec 22, 2017
@CyberShadow
Copy link
Copy Markdown
Member

CyberShadow commented Dec 22, 2017

Thanks!

@wilzbach wilzbach deleted the appveyor branch December 22, 2017 14:17
@wilzbach
Copy link
Copy Markdown
Contributor Author

wilzbach commented Dec 22, 2017

As mentioned this is very basic and should be replaced with an "official" powershell install script once we have one ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinNowak MartinNowak MartinNowak left review comments

@PetarKirov PetarKirov PetarKirov approved these changes

Assignees

No one assigned

Labels

auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wilzbach @dlang-bot @CyberShadow @MartinNowak @PetarKirov