Skip to content

Unify changelogs and insert generic macros#252

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:unify-nightly-changelog
Dec 13, 2017
Merged

Unify changelogs and insert generic macros#252
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:unify-nightly-changelog

Conversation

@wilzbach
Copy link
Copy Markdown
Contributor

Step (2) of dlang/dlang.org#1838

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Copy Markdown
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs the dlang.org changes of course. Would be good to look at the HTML diff here again once that's in.

@wilzbach wilzbach force-pushed the unify-nightly-changelog branch from a98260a to 807c0c3 Compare December 13, 2017 22:35
@wilzbach
Copy link
Copy Markdown
Contributor Author

diff --git a/web/changelog/pending.html b/web/changelog/pending.html
index 68b8ee3..c237645 100644
--- a/web/changelog/pending.html
+++ b/web/changelog/pending.html
@@ -206,6 +206,7 @@ Log</option>
 <div class="version"><p><b><font size="4"><a href="http://nightlies.dlang.org">Download D nightlies</a></font></b><br>
 <small>To be released</small>
 </p>
+
 <div class="bugsfixed"><h4>Compiler changes</h4> <ol>
 <li><a href="#PR7356"><span class="d_inlinecode donthyphenate notranslate">opDispatch</span> resolution in <span class="d_inlinecode donthyphenate notranslate">with</span> statements</a></li>
 <li><a href="#body">Generate header files using <span class="d_inlinecode donthyphenate notranslate">do</span> instead of <span class="d_inlinecode donthyphenate notranslate">body</span> as per DIP1003</a></li>

HTML diff looks great :)

@CyberShadow
Copy link
Copy Markdown
Member

Why do we have AppVeyor on here? I don't even see an appveyor.yml.

@dlang-bot dlang-bot merged commit f1d60cd into dlang:master Dec 13, 2017
@wilzbach wilzbach deleted the unify-nightly-changelog branch December 13, 2017 23:11
@wilzbach
Copy link
Copy Markdown
Contributor Author

Why do we have AppVeyor on here? I don't even see an appveyor.yml.

I was working on it a couple of days ago, so I enabled it to be able to try it out:

#269

I will disable the hook for now until we have an appveyor.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants