Show all contributors of the upcoming release#1949
Show all contributors of the upcoming release#1949wilzbach wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
For the script used to query the contributors, see dlang/tools#253 |
wilzbach
force-pushed
the
list-contributors
branch
5 times, most recently
from
eadb6ca to
91c1031
Compare
wilzbach
requested review from
CyberShadow,
MartinNowak and
andralex
as code owners
wilzbach
force-pushed
the
list-contributors
branch
from
91c1031 to
03a39ee
Compare
posix.mak
Outdated
| [ -f changelog/pending.dd ] || $(STABLE_RDMD) $(TOOLS_DIR)/changed.d \ | ||
| $(CHANGELOG_VERSION_LATEST) -o changelog/pending.dd --version "${NEXT_VERSION}" \ | ||
| --date "To be released" --nightly | ||
| changelog/pending.dd: $(TOOLS_DIR)/contributors.d $(TOOLS_DIR)/changed.d $(CHANGELOG_FILES) changelog/next-version | ${STABLE_DMD} $(TOOLS_DIR) $(INSTALLER_DIR) |
There was a problem hiding this comment.
make: *** No rule to make target 'changelog/2.033', needed by 'changelog/pending.dd'. Stop.
$(CHANGELOG_FILES) is not suitable as a target/dependency name directly, because it does not contain file extensions (they are being stripped by basename).
There was a problem hiding this comment.
Oh that error is due to Martin renaming it one day ago (-> https://github.com/dlang/dlang.org/pull/1953/files) and myself forgetting about it in the rebase.
wilzbach
force-pushed
the
list-contributors
branch
from
03a39ee to
85c0a72
Compare
|
Not necessary for this PR but it would be awesome to have a section noting any completely new contributors. |
|
Btw if you don't want to have the |
-> #1977 |
4 participants
An initial start at showing this information in the generated changelog.
...
This is proof of concept as I would prefer to go without the ugly perl replace hack, i.e. by having clearer templates in the changelog generator (dlang/tools#252).
OTOH this is ready now, works and can be shown on the next changelog. We can always improve it once dlang/tools#252 is in.
This currently only adds the list of contributors to the pending changelog file, but as the changelog generation will be changed soon (e.g. #1907), imho it's better to start small.