Add macros for replacement with _pending#1838
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
| $(SMALL $1) | ||
| ) | ||
| $4 | ||
| ) |
There was a problem hiding this comment.
How about leaving this in but removing it later so that we don't break the _pre page interim?
There was a problem hiding this comment.
This should no longer be an issue.
changelog/changelog.ddoc
Outdated
| ) | ||
| $4 | ||
| ) | ||
| SEP_HEADER_TEXT_NONEMPTY=$(BR)$(BIG $(RELATIVE_LINK2 bugfix-list, List of all bug fixes and enhancements in D $(VER).)) |
There was a problem hiding this comment.
Some comments describing what these macros do and where they're used sure would be nice.
| SPEC_DDOC=${DDOC} spec/spec.ddoc | ||
| CHANGELOG_DDOC=${DDOC} changelog/changelog.ddoc $(NODATETIME) | ||
| CHANGELOG_PRE_DDOC=${CHANGELOG_DDOC} changelog/prerelease.ddoc | ||
| CHANGELOG_PENDING_DDOC=${CHANGELOG_DDOC} changelog/pending.ddoc |
There was a problem hiding this comment.
Would be good to start maintaining some documentation of how the changelog is built. A description or link to one here and the .ddoc files would be nice.
There was a problem hiding this comment.
Done. I put the description in the respective changelog section
posix.mak
Outdated
| changelog/${NEXT_VERSION}_pre.dd: | ${STABLE_DMD} ../tools ../installer | ||
| $(STABLE_RDMD) $(TOOLS_DIR)/changed.d $(CHANGELOG_VERSION_MASTER) -o $@ \ | ||
| --version "${NEXT_VERSION} (upcoming)" --date "To be released" --nightly | ||
| --version "${NEXT_VERSION} (upcoming)" --date "To be released" |
There was a problem hiding this comment.
The changed invocations for _pre and _pending look identical right now. Aren't they supposed to be for different things (master/stable)?
I think you meant to link to dlang/tools#252. |
wilzbach
force-pushed
the
pending
branch
2 times, most recently
from
fbcf65c to
d5485e0
Compare
|
So I have finally found time to rebase this. If I have done this right, zero changes should appear on DAutoTest diff ... |
This is intended to replace the `--nightly` CLI flag of the changed script.
🎉 |
3 participants
See #1821 (comment) and dlang/tools#251 (comment)
Step 1) Add new macros
prerelease.ddoc, a ddoc file is used to overwrite the definitionsStep 2) Replace full text with macros at the
change.dtool (dlang/tools#252)Step 3) Add option to parse
BUGSTITLE_TEXT_BODYand generate a "incremental" changelog