This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Add currency selector for salary field#34
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds currency support to the salary field in job applications, enabling users to track salaries in USD, EUR, or GBP. The feature includes automatic currency detection based on timezone/locale and a currency selector in the UI.
- Introduces a currency field in the data model with validation
- Implements smart default currency detection using timezone and locale fallbacks
- Updates the UI to display a currency selector alongside the salary input
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/applications/applications-client.tsx | Adds currency constants, detection logic, selector UI, and form state management |
| convex/schema.ts | Adds optional currency field to applications table |
| convex/applications.ts | Adds currency validation and handling in create/update mutations |
…e across application
…urozone data structures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.