This repository was archived by the owner on Apr 11, 2026. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add currency selector for salary field #34
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1ae9982
feat: add currency selector for salary field
dmrock de1ef65
feat: implement currency validation across application and schema
dmrock 9597475
refactor: streamline currency validator definition in applications an…
dmrock a0ab6f9
feat: update currency type in updateApplication mutation to use Curre…
dmrock cea522b
feat: add shared currency constants and validator for consistent usag…
dmrock e05df01
feat: update currency handling to use DEFAULT_CURRENCY and optimize E…
dmrock 443b666
feat: add aria-label for currency select in applications client
dmrock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * Shared constants and validators used by both Convex backend and frontend. | ||
| * This file should NOT import any Convex server modules (query, mutation, etc.) | ||
| * to allow safe browser imports. | ||
| */ | ||
| import { v } from "convex/values"; | ||
|
|
||
| export const CURRENCIES = ["USD", "EUR", "GBP"] as const; | ||
| export type Currency = (typeof CURRENCIES)[number]; | ||
|
|
||
| // Validator for currency field - use in schema and mutations | ||
| export const currencyValidator = v.union(v.literal("USD"), v.literal("EUR"), v.literal("GBP")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.