Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

wip: toolchain containerization#283

Closed
vdemeester wants to merge 10 commits into
docker-archive-public:masterfrom
vdemeester:94-ctrn-toolchain
Closed

wip: toolchain containerization#283
vdemeester wants to merge 10 commits into
docker-archive-public:masterfrom
vdemeester:94-ctrn-toolchain

Conversation

@vdemeester
Copy link
Copy Markdown
Contributor

foo

Signed-off-by: Simon Ferquel simon.ferquel@docker.com

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2018

Codecov Report

Merging #283 into master will increase coverage by 0.68%.
The diff coverage is 62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   47.68%   48.37%   +0.68%     
==========================================
  Files          40       40              
  Lines        2850     2888      +38     
==========================================
+ Hits         1359     1397      +38     
+ Misses       1285     1277       -8     
- Partials      206      214       +8
Impacted Files Coverage Δ
internal/names.go 100% <ø> (ø) ⬆️
internal/packager/registry.go 64.65% <58.33%> (-2.38%) ⬇️
internal/packager/packing.go 35.82% <71.42%> (+35.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534b753...18496d6. Read the comment docs.

simonferquel and others added 3 commits July 9, 2018 16:15
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@vdemeester vdemeester force-pushed the 94-ctrn-toolchain branch from 95fecfb to 8768dc0 Compare July 9, 2018 14:15
vdemeester and others added 2 commits July 9, 2018 16:19
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@vdemeester vdemeester requested a review from chris-crone as a code owner July 11, 2018 08:05
@mat007
Copy link
Copy Markdown
Contributor

mat007 commented Jul 11, 2018

Is this linked to an issue in the backlog?

Comment thread .gitignore
.gradle
coverage.html
cover.out
.vscode/ No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing \n

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR up: #289

rpc Print(PrintRequest) returns(google.protobuf.Empty);
rpc FileContent(google.protobuf.StringValue) returns (stream google.protobuf.BytesValue);
rpc FileList(google.protobuf.StringValue) returns (stream FileStat);
} No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
…sefile)

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@vdemeester vdemeester closed this Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants