Upgrade containerd version and update containerd executor#2595
Upgrade containerd version and update containerd executor#2595svenpopping wants to merge 9 commits into
Conversation
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
Signed-off-by: Sven Popping <sven@popping.co>
|
The failing test is the same as in issue #2559 |
|
This is awesome! My recommendation would be to update to the |
|
@svenpopping I opened a PR to (temporarily, if this PR gets accepted) remove the unused flags; #2704 If that one gets merged; you can revert the change as part of this PR 👍 |
|
I don't have bandwidth for a full review, but FWIW I'm happy to see the code resurrected and maintained. @stevvooe's recommendation to use the containerd master client is a good one, although it might be wise to arrange for CI testing of the different Somewhat unrelated but IMHO the IDE related |
Ah, yes wanted to point to https://github.com/moby/moby/blob/e5cce50c7ea727c1c901b6e1443bd4291d62fce3/.gitignore#L2-L3 - perhaps we should add a similar line in this repository |
In PR #2568 the "containerd" executor was removed, because it targeted an older version of containerd which was not being maintained anymore.
This PR aims to reintroduce the containerd executor (v1.0.2). This version is being actively maintained.
In the case this PR does not get merged, maybe the following lines, which seem to be related to the previous containerd implementation, should be removed: