This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] Completion cherry picks#135
Merged
andrewhsu merged 11 commits intodocker-archive:17.06from Jul 26, 2017
Merged
Conversation
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 36b572dfdf6bc7b2519f494afe93130e3a8718b5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This adds bash completion for moby/moby#32406. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 1f8720717d58597cb4474e70fa6d534db132229b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This adds bash completion for moby/moby#30891. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 1d21a3dd7c4ffff80c093c005b910a131e7fc05a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…ity` This adds bash completion for moby/moby#32874. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 2caf425f02363a5894b5790dcde47a11808d23e1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This adds bash completion for - docker/cli#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit c40952b3058db3c6e44bca8c518d888b83878ce5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 211bd55ae736705a48908833a5e10491f613e255) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The completion logic should be implemented in the documented subcommands (ls, rm) and delegated to from the aliases (list, remove). For the rm|remove pair, this was implemented vice versa. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit d585e554d5e3a16f424cb3d92d0f7be342b8c7ca) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
bash completion usually completes boolean options that default to `true` with the `=false` suffix because that is the only syntax that really changes behavior. For this option, I implemented completion falsely. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit fc0dafbbd11130ac24f8905f697b71e99f32d4e6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr> (cherry picked from commit 6b256484ae3cb4da78e6ddad75b8aaf552b9ae60) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr> (cherry picked from commit d7ade64d29965a686ce7933865d273e84f1ccce1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…etion Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr> (cherry picked from commit 6c65ba6c0836ed14501cb40ad2d82cdde6fd168d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
|
LGTM for the zsh part. 👍 |
Contributor
|
LGTM for the bash completion part - all completions were successfully verified |
Member
Author
|
Thanks both! ping @andrewhsu |
Contributor
|
Re-kicked windows build, failure was unrelated to the PR |
seemethere
approved these changes
Jul 25, 2017
Contributor
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
All tests pass 👍 LGTM
andrewhsu
changed the title
Member
Author
|
ping @andrewhsu for merge |
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 7, 2018
Merged with https://github.com/seemethere/unir Upstream-commit: 0b37662 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Feb 22, 2019
[18.09 backport] Ignore xattr ENOTSUP errors on copy (fixes #38155) Upstream-commit: db7a8cb7ba2de79d68ec73c158571319f82ba212 Component: engine
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash completion fixes:
system prune --volumesdocker/cli#254 docker/cli@36b572dbuild --iidfiledocker/cli#279 docker/cli@1f87207plugin ls --filter capabilitydocker/cli#281 docker/cli@2caf425docker configcommand family docker/cli#283 docker/cli@c40952b docker/cli@211bd55 docker/cli@d585e55service create|update --detach|-ddocker/cli#284 docker/cli@fc0dafbZSH completion fixes:
system prune --volumesdocker/cli#368 docker/cli@6b25648ping @andrewhsu @albers @jphuynh PTAL