Add bash completion for docker config command family#283
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
======================================
Coverage 48.7% 48.7%
======================================
Files 185 185
Lines 12168 12168
======================================
Hits 5926 5926
Misses 5875 5875
Partials 367 367 |
albers
force-pushed
the
completion-configs
branch
from
e400b90 to
b5964ac
Compare
Contributor
|
@albers do you think it'd be possible to have path completion enabled for i.e.: correctly doesn't offer suggestion but Doesn't either, and I would have expected it to do so. |
This adds bash completion for - docker#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
The completion logic should be implemented in the documented subcommands (ls, rm) and delegated to from the aliases (list, remove). For the rm|remove pair, this was implemented vice versa. Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
completion-configs
branch
from
b5964ac to
d585e55
Compare
Collaborator
Author
|
@mlaventure Nice catch, thanks a lot. I added path completion to |
mlaventure
approved these changes
Jul 7, 2017
Contributor
mlaventure
left a comment
mlaventure
left a comment
There was a problem hiding this comment.
Thanks!
It works perfectly now, amazing job as always, really appreciated :)
LGTM
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.11] Add Ubuntu Artful (17.10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bash completion for #45.
Ping @sdurrheimer for zsh completion
Additional commits add related functionality/refactorings:
secret inspect --pretty(Ref: Add --pretty option to "secret inspect" and "config inspect" #88)secret rm|remove