Add file completion to bash completion for secret create#383
Merged
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
improve-completion-secret-create
branch
from
e45c5bb to
abc793e
Compare
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 46.14% 46.14%
=======================================
Files 193 193
Lines 16073 16073
=======================================
Hits 7417 7417
Misses 8269 8269
Partials 387 387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like completion for
docker config create,docker secret createshould have file completion.See #283 (comment).
Note: #266 changed all instances of
$((counter + 1))to"$((counter + 1))", so I fixed one instance that was introduced in a PR that was pending when #266 got merged.