This repository was archived by the owner on Oct 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[17.10] backport doc fixes and shell completion script fixes #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for `docker service create|update|scale|rollback --detach|-d` changed from `true` to `false`. This updates bash completion to complete just `--detach|-d`. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 60bfaba6fbf33b14ce1ae59fda396fe57dbfdc7c) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
- The default was not changed in 17.09 but will be in 17.10 - `service scale` and `service rollback` are also affected. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 20d9ceca7859269778851c27b6b0aadd02a325a1) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Also adds minimal documentation for this flag. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 9559b9b7a8707b4c83d53bdb5b5a7cbe00b241c0) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 1d7a31f87e8c85ef6ef0a3d9987e308cf35e4841) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Daniel Goosen <daniel.goosen@surveysampling.com> (cherry picked from commit 9004495541cfa99a2850a60fccb990a054fe6df4) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Commit ddadd3db494ce568a6b847932677f837802ea6b5 changed the heading levels of various sections, but as a result, the "daemon configuration file" section (and other sections) changed from a H2 to a H4, therefore no longer showing up in the page's TOC / navigation bar. This patch changes the heading level to a H3 for sections that should show up in the page navigation. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit aca0421eb8ed55534d0083739d7deefbb25f6130) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Markdown nested in a HTML table doesn't work, so changing the link to a plain HTML link. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6b6511f1914199d868e5a7c1591b14a52ba4842a) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Contributor
Author
|
cc @albers |
mdlinville
approved these changes
Oct 11, 2017
thaJeztah
approved these changes
Oct 11, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
[17.10] backport doc fixes and shell completion script fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All cherry-picks went in clean, no conflicts.
docker/cli#610 Update bash completion and deprecation for synchronous service updates
docker/cli#611 Add bash completion for
stack deploy --resolve-imagedocker/cli#618 Add bash completion for
secret create --driverdocker/cli#580 Update rmi.md
docker/cli#598 Fix dockerd reference heading levels
docker/cli#603 Fix markdown link in service-create reference docs