Skip to content

Conversation

@djgoosen
Copy link
Contributor

@djgoosen djgoosen commented Oct 2, 2017

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:djgoosen/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

codecov-io commented Oct 2, 2017

Codecov Report

Merging #580 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   49.41%   49.38%   -0.04%     
==========================================
  Files         208      208              
  Lines       17186    17178       -8     
==========================================
- Hits         8493     8483      -10     
- Misses       8261     8262       +1     
- Partials      432      433       +1

Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commit and use a more informative title for your pull request. Thanks!

Signed-off-by: Daniel Goosen <daniel.goosen@surveysampling.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants