This repository was archived by the owner on Oct 13, 2023. It is now read-only.
container/stream/attach: use pools.Copy #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (cherry picked from commit ba40f45)
The use of pools.Copy avoids io.Copy's internal buffer allocation. This commit replaces io.Copy with pools.Copy to avoid the allocation of buffers in io.Copy. Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (cherry picked from commit 014095e)
Contributor
|
We can close this in favor of #76 because it makes the same changes and CI passes for that PR. |
Contributor
Author
|
Not sure why this one didn't pass, they were identical :) |
Contributor
|
It was actually my mistake that I opened up an identical PR...I didn't check for this PR beforehand, sorry about that. Was trying to get this PR green before merging, but kept the other as backup for its green status. Seems like this PR was having issues with dockerhub responses from its test job: In any case, the changeset has been merged in #76 |
andrewhsu
pushed a commit
that referenced
this pull request
Nov 29, 2017
Add new CLI option for --until Upstream-commit: 026c6db6f6d00bc9445d6138964a326c63233842 Component: cli
docker-jenkins
pushed a commit
that referenced
this pull request
Dec 29, 2017
Move .PHONY targets above actual targets Upstream-commit: 41ae603 Component: packaging
andrewhsu
added a commit
that referenced
this pull request
Apr 26, 2018
[18.03] vndr hcsshim to 79062a5
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 6, 2018
…mismatch [18.09 backport] remove version-checks for containerd and runc Upstream-commit: f5749085e9cb0565afe342e73a67631f97547054 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Move .PHONY targets above actual targets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevent the daemon from consuming enormous amount of memory when a lot of containers are being started and stopped.
Cherry pick of moby/moby#33472