This repository was archived by the owner on Oct 13, 2023. It is now read-only.
cherry-pick container/stream/attach: use pools.Copy #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of pools.Copy avoids io.Copy's internal buffer allocation. This commit replaces io.Copy with pools.Copy to avoid the allocation of buffers in io.Copy. Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (cherry picked from commit 014095e) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (cherry picked from commit ba40f45) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2 tasks
Contributor
Author
|
LGTM tests are green |
andrewhsu
added a commit
that referenced
this pull request
Apr 26, 2018
[18.05] bump version to 18.05.0-ce-rc1
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 9, 2018
Switch copy image to a docker org based one Upstream-commit: ad08dc12e090bce989ae701ec04f22c26b20d6cf Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
cherry-pick container/stream/attach: use pools.Copy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the commits from:
To fix: