Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.09] Vendor swarmkit to 6186e40#104

Merged
andrewhsu merged 1 commit intodocker-archive:18.09from
anshulpundir:1809
Nov 1, 2018
Merged

[18.09] Vendor swarmkit to 6186e40#104
andrewhsu merged 1 commit intodocker-archive:18.09from
anshulpundir:1809

Conversation

@anshulpundir
Copy link
Copy Markdown

@anshulpundir anshulpundir commented Oct 31, 2018

Upstream changes: moby/swarmkit@c82e409...6186e40

Brings in moby/swarmkit#2775

continuation on previous fix #99

This PR addresses the same grpc max message size issue for multi-manager swarm.

ping @andrewhsu @thaJeztah @dperny @tonistiigi

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
@andrewhsu andrewhsu changed the title [18.09] Vendor swarmkit to 6186e40fb04a7681e25a9101dbc7418c37ef0c8b [18.09] Vendor swarmkit to 6186e40 Oct 31, 2018
Copy link
Copy Markdown

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

Copy link
Copy Markdown

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Make sure to update moby as well)

@thaJeztah
Copy link
Copy Markdown
Member

backport-pr in swarmkit; moby/swarmkit#2776

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

and yes, we should be sure to have this fix on master as well 😅

@andrewhsu andrewhsu merged commit 4fc9786 into docker-archive:18.09 Nov 1, 2018
@thaJeztah
Copy link
Copy Markdown
Member

Pull request for master: moby#38123

@anshulpundir
Copy link
Copy Markdown
Author

and yes, we should be sure to have this fix on master as well 😅

on my list!

@thaJeztah thaJeztah added this to the 18.09.0 milestone Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants