Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.09] cluster: set bigger grpc limit for array requests#99

Merged
andrewhsu merged 1 commit into
docker-archive:18.09from
andrewhsu:grpc
Oct 31, 2018
Merged

[18.09] cluster: set bigger grpc limit for array requests#99
andrewhsu merged 1 commit into
docker-archive:18.09from
andrewhsu:grpc

Conversation

@andrewhsu
Copy link
Copy Markdown

@andrewhsu andrewhsu commented Oct 30, 2018

backport:

to address:

git cherry-pick moby@489b8ed

$ git cherry-pick -s -x 489b8eda6674523df8b82a210399b7d2954427d0
[grpc 6ca0546f25] cluster: set bigger grpc limit for array requests
 Author: Tonis Tiigi <tonistiigi@gmail.com>
 Date: Mon Oct 29 17:44:11 2018 -0700
 3 files changed, 13 insertions(+), 5 deletions(-)

no conflicts

@andrewhsu andrewhsu added this to the 18.09.0 milestone Oct 30, 2018
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 30, 2018

@andrewhsu the upstream PR was updated (only the commit message); can you cherry-pick the new commit? moby@f1f50ed f1f50eddae5e15c0f5fd3b7f16fa7fef253f869c

4MB client side limit was introduced in vendoring go-grpc#1165 (v1.4.0)
making these requests likely to produce errors

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 489b8ed)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu merged commit fb51c76 into docker-archive:18.09 Oct 31, 2018
@andrewhsu andrewhsu deleted the grpc branch October 31, 2018 01:49
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also addresses moby#37941. Related: moby#36895 (pull request that brought in the updated grpc version) moby/swarmkit#2774 (tracking issue for looking at the message size)

@rnz
Copy link
Copy Markdown

rnz commented Mar 26, 2019

dockerd[2888]: time="2019-03-27T02:27:29.990822362+03:00" level=error msg="agent: session failed" backoff=100ms error="rpc error: code = ResourceExhausted desc = grpc: received message larger than max (4270560 vs. 4194304)" module=node/agent node.id=7wittan6h0xbkva01kuy1empm

Server Version: 18.09.3
Kernel Version: 4.19.0-0.bpo.2-cloud-amd64
Operating System: Debian GNU/Linux 9 (stretch)
Architecture: x86_64

docker service list | wc -l 667

@vsenapathy
Copy link
Copy Markdown

vsenapathy commented Oct 12, 2021

Is this fix part of 18.09.9? also i see that @rnz got an error on 18.09.3. So i have a around 600 services also. Will i get the same error

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants