This repository was archived by the owner on Oct 13, 2023. It is now read-only.
Revert "[18.09 backport] API: fix status code on conflicting service names"#142
Merged
Merged
Conversation
seemethere
approved these changes
Dec 28, 2018
seemethere
previously requested changes
Dec 28, 2018
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
Needs a DCO,
git commit --amend -s --no-edit && git push -f
…names" Signed-off-by: Madhu Venugopal <madhu@docker.com>
mavenugo
force-pushed
the
revert-130-18.09_backport_fix_api_return_code
branch
from
84728b1 to
24f71e3
Compare
Author
|
@seemethere updated. |
Member
|
PowerPC failure is a known flaky test, and unrelated (tracked through moby#32673) |
Member
|
Follow-up; moby/swarmkit#2797 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #130
Unfortunately, since the Client library doesn't return the status code, the applications that rely on the error messages (though not a good idea), will be broken. Though this is a good fix, it will cause regression in a minor release and hence reverting the changes.