This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] API: fix status code on conflicting service names#130
Merged
andrewhsu merged 2 commits intoDec 13, 2018
Merged
Conversation
This updates the swarmkit vendoring to the latest version in the bump_v18.09 branch Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit b0de11c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
andrewhsu
approved these changes
Dec 10, 2018
andrewhsu
left a comment
andrewhsu
left a comment
There was a problem hiding this comment.
LGTM on green
i see flakey failure on experimental that is not a blocker for this merge:
FAIL: docker_cli_swarm_test.go:1376: DockerSwarmSuite.TestSwarmClusterRotateUnlockKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports of;
Updates swarmkit to the latest version in the bump_18.09 branch;
moby/swarmkit@6186e40...d61ff76
- Description for the changelog