This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.09] Remove boltdb dependency#60
Merged
andrewhsu merged 8 commits intodocker-archive:18.09from Sep 22, 2018
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
… is expected now with buildkit Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 5aa222d) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This allows users to configure the buildkit GC.
The following enables the default GC:
```
{
"builder": {
"gc": {
"enabled": true
}
}
}
```
The default GC policy has a simple config:
```
{
"builder": {
"gc": {
"enabled": true,
"defaultKeepStorage": "30GB"
}
}
}
```
A custom GC policy can be used instead by specifying a list of cache prune rules:
```
{
"builder": {
"gc": {
"enabled": true,
"policy": [
{"keepStorage": "512MB", "filter": ["unused-for=1400h"]]},
{"keepStorage": "30GB", "all": true}
]
}
}
}
```
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 4a776d0)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit d0f00bc) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This also brings in these PRs from swarmkit: - moby/swarmkit#2691 - moby/swarmkit#2744 - moby/swarmkit#2732 - moby/swarmkit#2729 - moby/swarmkit#2748 Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
18.09-remove-boltdb
branch
from
e3fbb5f to
cce1763
Compare
Author
|
Ping @jhowardmsft @thaJeztah it seems like libnetwork bump was not needed afterall, since libnetwork's dependency on boltdb is indirect: libnetwork uses libkv which depends on boltdb. I only see now that @thaJeztah already had a similar PR #54. I think they're mutually exclusive. |
|
I don't think it hurts. Thanks for getting this done - I've been swamped. I assume this is in moby/moby? I didn't see the PR go past, but maybe I wasn't tagged in it. |
This was referenced Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #59
vendor: remove boltdb dependency which is superseded by bbolt
This also brings in these PRs from swarmkit: